On Sun, 2 Aug 2015 19:08:30 +0900 Roger Shimizu <rogershimizu@gmail.com> wrote: > Dear Ian, > > Thanks for your feedback! > > After reading your comment, I reviewed the whole procedure of loading > netconsole module during initramfs-tools booting, previously and after > my patch, I start to consider that original "modprobe netconsole > netconsole=$param" line in init file is merely a dirty hack. The real > fix is to load the netconsole module with param inside load_modules() > routine. > > So I created v3 patchset, which looks more clean to me. > Of course patchset v2 & v3 both works well as I tested. So I let the > package maintainer to choose which is better to merge. [...] An initramfs built with MODULES=most (default) always includes netconsole.ko (assuming it was enabled in the kernel configuration). So the netconsole parameter needs to work even if netconsole doesn't appear in /conf/modules, and your v3 breaks that. So I applied your v2. Thanks. Ben. -- Ben Hutchings I'm always amazed by the number of people who take up solipsism because they heard someone else explain it. - E*Borg on alt.fan.pratchett
Attachment:
signature.asc
Description: This is a digitally signed message part