[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#771340: marked as done (linux-tools-3.16: perf not built for arm64)

Your message dated Sun, 01 Feb 2015 11:00:07 +0000
with message-id <E1YHsG7-0003eF-IA@franck.debian.org>
and subject line Bug#771340: fixed in linux-tools 3.18.5-1~exp1
has caused the Debian Bug report #771340,
regarding linux-tools-3.16: perf not built for arm64
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
771340: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771340
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-tools-3.16
Severity: important
Tags: patch

Dear Maintainer,

For arm64, perf is not being built for Jessie.

I have attached a patch which works for me on a Juno board.

A kernel patch is cherry-picked to fix a perf build bug (this only
affects the arm64 tree).

Also, I have modified the build-dep to explicitly pull in binutils-dev.
(I found that both binutils-dev and libiberty are needed for C++
demangling support).

Some other build logic is altered in particular the architectures list
is now set to: linux-any; and the install-tools rule is now an
unconditional dependency for binary-arch, this took me *ages* to
find :-(.

Please let me know if I've missed anything obvious or you would like me
to run additional tests.

Cheers,
-- 
Steve

diff -Nru linux-tools-3.16/debian/build/tools/perf/Makefile linux-tools-3.16/debian/build/tools/perf/Makefile
--- linux-tools-3.16/debian/build/tools/perf/Makefile	2014-09-09 05:06:33.000000000 +0000
+++ linux-tools-3.16/debian/build/tools/perf/Makefile	2014-11-28 14:08:45.000000000 +0000
@@ -12,6 +12,8 @@
   NO_LIBUNWIND=
 else ifeq ($(DEB_HOST_ARCH_CPU),arm)
   KERNEL_ARCH_PERF = arm
+else ifeq ($(DEB_HOST_ARCH_CPU),arm64)
+  KERNEL_ARCH_PERF = arm64
 else ifeq ($(DEB_HOST_ARCH_CPU),hppa)
   KERNEL_ARCH_PERF = parisc
 else ifeq ($(DEB_HOST_ARCH_CPU),i386)
diff -Nru linux-tools-3.16/debian/control linux-tools-3.16/debian/control
--- linux-tools-3.16/debian/control	2014-09-09 12:23:52.000000000 +0000
+++ linux-tools-3.16/debian/control	2014-11-28 15:09:07.000000000 +0000
@@ -4,7 +4,7 @@
 Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
 Uploaders: Bastian Blank <waldi@debian.org>, Ben Hutchings <ben@decadent.org.uk>, Jonathan Nieder <jrnieder@gmail.com>
 Standards-Version: 3.9.4
-Build-Depends: debhelper (>> 7), python, asciidoc, bison, flex, libaudit-dev, libdw-dev, libelf-dev, libiberty-dev | binutils-dev (<< 2.23.91.20131123-1), libnewt-dev, libnuma-dev [amd64 i386 powerpc ppc64 ppc64el], libperl-dev, libunwind8-dev [amd64 i386], python-dev, xmlto, autoconf, automake, libtool, libglib2.0-dev, libudev-dev, libwrap0-dev
+Build-Depends: debhelper (>> 7), python, asciidoc, bison, flex, libaudit-dev, libdw-dev, libelf-dev, libiberty-dev, binutils-dev, libnewt-dev, libnuma-dev [amd64 i386 powerpc ppc64 ppc64el], libperl-dev, libunwind8-dev [amd64 i386], python-dev, xmlto, autoconf, automake, libtool, libglib2.0-dev, libudev-dev, libwrap0-dev
 Vcs-Svn: svn://svn.debian.org/svn/kernel/dists/trunk/linux-tools/
 Vcs-Browser: http://anonscm.debian.org/viewvc/kernel/dists/trunk/linux-tools/
 
@@ -17,7 +17,7 @@
 Multi-Arch: foreign
 
 Package: linux-tools-3.16
-Architecture: alpha amd64 armel armhf hppa i386 powerpc ppc64 ppc64el s390 s390x sh4 sparc sparc64
+Architecture: linux-any
 Section: devel
 Depends: ${shlibs:Depends}, ${misc:Depends}, ${perl:Depends}, ${python:Depends}
 Recommends: linux-base (>= 3.4~)
diff -Nru linux-tools-3.16/debian/control.md5sum linux-tools-3.16/debian/control.md5sum
--- linux-tools-3.16/debian/control.md5sum	2014-09-09 12:23:52.000000000 +0000
+++ linux-tools-3.16/debian/control.md5sum	2014-11-28 15:09:07.000000000 +0000
@@ -1,4 +1,4 @@
 ac3acacf0cde6d2cc424f28241bb0857  debian/bin/gencontrol.py
 e22c0d8272eb6d18751657807e50bc3f  debian/changelog
-d85b23bb34d1fc562998ab0c6117ff28  debian/templates/control.main.in
-96d01c999dbb871c3c6fecaad4b4901c  debian/templates/control.source.in
+6167d5526bfd33090891989b0ab3d9ff  debian/templates/control.main.in
+39974d9874415912d0e40cef24b78c46  debian/templates/control.source.in
diff -Nru linux-tools-3.16/debian/patches/fix-arm64-build.patch linux-tools-3.16/debian/patches/fix-arm64-build.patch
--- linux-tools-3.16/debian/patches/fix-arm64-build.patch	1970-01-01 00:00:00.000000000 +0000
+++ linux-tools-3.16/debian/patches/fix-arm64-build.patch	2014-11-28 16:16:52.000000000 +0000
@@ -0,0 +1,44 @@
+From: Steve Capper <steve.capper@linaro.org>
+Date: Fri, 28 Nov 2014 16:15:00 +0000
+Subject: Cherry-pick perf fix for arm64
+
+This is a cherry-pick of the following commit, needed for perf to build
+on arm64.
+
+commit 7d885749b6de2c9a1168d566e2380207b9177108
+Author: Mark Salter <msalter@redhat.com>
+Commit: Arnaldo Carvalho de Melo <acme@redhat.com>
+
+    perf tools: Fix arm64 build error
+    
+    I'm seeing the following build error on arm64:
+    
+      In file included from util/event.c:3:0:
+      util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
+        u64 cache_regs[PERF_REGS_MAX];
+                     ^
+    
+    This patch adds a PERF_REGS_MAX definition for arm64.
+    
+    Signed-off-by: Mark Salter <msalter@redhat.com>
+    Acked-by: Jean Pihet <jean.pihet@linaro.org>
+    Cc: Ingo Molnar <mingo@redhat.com>
+    Cc: Jean Pihet <jean.pihet@linaro.org>
+    Cc: Paul Mackerras <paulus@samba.org>
+    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
+    Link: http://lkml.kernel.org/r/1406325766-8085-1-git-send-email-msalter@redhat.com
+    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
+
+
+Index: linux-tools-3.16/tools/perf/arch/arm64/include/perf_regs.h
+===================================================================
+--- linux-tools-3.16.orig/tools/perf/arch/arm64/include/perf_regs.h
++++ linux-tools-3.16/tools/perf/arch/arm64/include/perf_regs.h
+@@ -6,6 +6,7 @@
+ #include <asm/perf_regs.h>
+ 
+ #define PERF_REGS_MASK	((1ULL << PERF_REG_ARM64_MAX) - 1)
++#define PERF_REGS_MAX	PERF_REG_ARM64_MAX
+ #define PERF_REG_IP	PERF_REG_ARM64_PC
+ #define PERF_REG_SP	PERF_REG_ARM64_SP
+ 
diff -Nru linux-tools-3.16/debian/patches/series linux-tools-3.16/debian/patches/series
--- linux-tools-3.16/debian/patches/series	2014-09-08 22:32:53.000000000 +0000
+++ linux-tools-3.16/debian/patches/series	2014-11-28 14:18:51.000000000 +0000
@@ -3,3 +3,4 @@
 tools-perf-install.patch
 usbip-document-tcp-wrappers.patch
 kbuild-fix-recordmcount-dependency.patch
+fix-arm64-build.patch
diff -Nru linux-tools-3.16/debian/rules.real linux-tools-3.16/debian/rules.real
--- linux-tools-3.16/debian/rules.real	2014-09-08 22:32:53.000000000 +0000
+++ linux-tools-3.16/debian/rules.real	2014-11-28 15:39:07.000000000 +0000
@@ -8,10 +8,7 @@
 # includes any binNMU part.
 VERSION_DEBIAN_FULL := $(shell dpkg-parsechangelog | sed -ne 's,^Version: *\(.*\)$$,\1,p')
 
-binary-arch: install-kbuild install-usbip
-ifneq ($(filter alpha amd64 armel armhf hppa i386 powerpc ppc64 ppc64el s390 s390x sh4 sparc sparc64,$(DEB_BUILD_ARCH)),)
-  binary-arch: install-tools
-endif
+binary-arch: install-kbuild install-usbip install-tools
 
 build: $(STAMPS_DIR)/build
 
diff -Nru linux-tools-3.16/debian/templates/control.main.in linux-tools-3.16/debian/templates/control.main.in
--- linux-tools-3.16/debian/templates/control.main.in	2014-09-08 22:32:53.000000000 +0000
+++ linux-tools-3.16/debian/templates/control.main.in	2014-11-28 14:55:53.000000000 +0000
@@ -7,7 +7,7 @@
 
 Package: linux-tools-@version@
 Section: devel
-Architecture: alpha amd64 armel armhf hppa i386 powerpc ppc64 ppc64el s390 s390x sh4 sparc sparc64
+Architecture: linux-any
 Depends: ${shlibs:Depends}, ${misc:Depends}, ${perl:Depends}, ${python:Depends}
 Recommends: linux-base (>= 3.4~)
 Suggests: linux-doc-@version@
diff -Nru linux-tools-3.16/debian/templates/control.source.in linux-tools-3.16/debian/templates/control.source.in
--- linux-tools-3.16/debian/templates/control.source.in	2014-09-08 22:32:53.000000000 +0000
+++ linux-tools-3.16/debian/templates/control.source.in	2014-11-28 15:00:53.000000000 +0000
@@ -6,7 +6,7 @@
 Standards-Version: 3.9.4
 Build-Depends:
  debhelper (>> 7), python,
- asciidoc, bison, flex, libaudit-dev, libdw-dev, libelf-dev, libiberty-dev | binutils-dev (<< 2.23.91.20131123-1), libnewt-dev, libnuma-dev [amd64 i386 powerpc ppc64 ppc64el], libperl-dev, libunwind8-dev [amd64 i386], python-dev, xmlto,
+ asciidoc, bison, flex, libaudit-dev, libdw-dev, libelf-dev, libiberty-dev, binutils-dev, libnewt-dev, libnuma-dev [amd64 i386 powerpc ppc64 ppc64el], libperl-dev, libunwind8-dev [amd64 i386], python-dev, xmlto,
  autoconf, automake, libtool, libglib2.0-dev, libudev-dev, libwrap0-dev
 Vcs-Svn: svn://svn.debian.org/svn/kernel/dists/trunk/linux-tools/
 Vcs-Browser: http://anonscm.debian.org/viewvc/kernel/dists/trunk/linux-tools/

--- End Message ---
--- Begin Message --- 
Source: linux-tools
Source-Version: 3.18.5-1~exp1

We believe that the bug you reported is fixed in the latest version of
linux-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 771340@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <ben@decadent.org.uk> (supplier of updated linux-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 01 Feb 2015 02:53:07 +0100
Source: linux-tools
Binary: linux-kbuild-3.18 linux-tools-3.18 libusbip-dev usbip
Architecture: i386 source
Version: 3.18.5-1~exp1
Distribution: experimental
Urgency: medium
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <ben@decadent.org.uk>
Closes: 763002 771340
Description: 
 libusbip-dev - USB device sharing system over IP network (development files)
 linux-kbuild-3.18 - Kbuild infrastructure for Linux 3.18
 linux-tools-3.18 - Performance analysis tools for Linux 3.18
 usbip      - USB device sharing system over IP network
Changes:
 linux-tools (3.18.5-1~exp1) experimental; urgency=medium
 .
   * New upstream release
   * linux-tools: Fix build configuration to avoid linking perf with libbfd
     (Closes: #763002)
   * linux-tools: Add a check that perf is not linked with libbfd
   * [arm64] Enable building linux-tools, thanks to Steve Capper
     (Closes: #771340)
   * [armel,armhf] linux-tools: Enable use of libunwind
   * [hppa,sparc] linux-tools: Enable use of libnuma
   * [mips*,powerpcspe,x32] Enable building linux-tools
Checksums-Sha1: 
 bf89ab6c838e319c178b11c4cdc17808e11d9553 2717 linux-tools_3.18.5-1~exp1.dsc
 05bfc0d68b04acb91e61d6b991e8b8499452f740 7990192 linux-tools_3.18.5.orig.tar.xz
 3cd5c861ffc15c6cf8db1370b5aa119a0bd103e6 23332 linux-tools_3.18.5-1~exp1.debian.tar.xz
 50bb8e148f440e5afc087d0188c259efac258a30 23444 libusbip-dev_2.0+3.18.5-1~exp1_i386.deb
 a1d36da8d1391426f4d512662c2798a593f5ff86 177446 linux-kbuild-3.18_3.18.5-1~exp1_i386.deb
 96029f0e15ed02eb7328e39d747d48598f280de0 37420 usbip_2.0+3.18.5-1~exp1_i386.deb
 2eba184c7a538b715d64992c12669ef75586a816 630304 linux-tools-3.18_3.18.5-1~exp1_i386.deb
Checksums-Sha256: 
 32bbaa39b2694cc0ffaa687a12add0f34a58d962ba5cf317dbac780c579cca50 2717 linux-tools_3.18.5-1~exp1.dsc
 bf79397874cc211e81eed47e2c2591632ba7b03d3de73aea867f2a78917b9720 7990192 linux-tools_3.18.5.orig.tar.xz
 681e464628349a427680817b84d13bbc441382e8a5b8054df67384db88cc06f3 23332 linux-tools_3.18.5-1~exp1.debian.tar.xz
 c598fac0fc3b6e388de2cd01d3dcc8199d61fbbb676c798e08d9c61861c8a1c0 23444 libusbip-dev_2.0+3.18.5-1~exp1_i386.deb
 51d5ef10fd3171c8f242d3cd0ad143014a2edb3fd39e7639b92ade63719adee4 177446 linux-kbuild-3.18_3.18.5-1~exp1_i386.deb
 1a102aeef4157c8bd8350d86ddfd45887e97f570d8d64ce9cd66ebe4772ec244 37420 usbip_2.0+3.18.5-1~exp1_i386.deb
 f992007c86f2da1bb6f30755140c143976f02ce59eda0715c020f75ce5aa4eea 630304 linux-tools-3.18_3.18.5-1~exp1_i386.deb
Files: 
 65c2b3ad6a3d9a6891af9669d1099dd4 2717 kernel optional linux-tools_3.18.5-1~exp1.dsc
 c9ee8f5c1f88e562f1c1d6997c442c7f 7990192 kernel optional linux-tools_3.18.5.orig.tar.xz
 c0a567aad12e7ed981695ed9ccd50b52 23332 kernel optional linux-tools_3.18.5-1~exp1.debian.tar.xz
 026deaf0d6eb3138d65669ad302645ee 23444 libdevel optional libusbip-dev_2.0+3.18.5-1~exp1_i386.deb
 3ab0897af33a6dbc184ca211427f7de6 177446 kernel optional linux-kbuild-3.18_3.18.5-1~exp1_i386.deb
 7b389d430d6a16bacc38e52e55e596d6 37420 admin optional usbip_2.0+3.18.5-1~exp1_i386.deb
 7a6de5123f2382d1f479062fb6536a9b 630304 devel optional linux-tools-3.18_3.18.5-1~exp1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBVM2Iree/yOyVhhEJAQp5kBAAguYSOWYayKmexPfYDhltfQUif9mwegY7
d9kkcUcwk81SLwOPx77AihOUClXcC4We82tHkXuToPwHVb2eifvFYvK0pbYHNBEU
CNIWBRngtJxOMX4v0RAXbCTtQ3h4SVjKoT9GBep2eaIQzpWT8H0xHSVKOxEyu4dO
kKxZQYEBDdLYwgKqgzQV1ntpLiaA2PSo2WZ5B2CjXlWIaL98vnDpwJeT0Ze9+5Qv
J87GKcd+LCUuT2zSrIo4c4nxCO9m+nEqy+fLUg9lFks0R6EZ33LQn1KVPZWs6f2D
vMnEg4p/+ypej38W9vnIFsAQX8mofTNIKO3HnC4Kgwf0CEgC0VAE5vr1DyDeJt/N
Cb+xB6JLDRIwQf5gjbj8s/c42KsZgrweBbaIr9Hrk0GlOcOyPysQZQPjf2MI419A
C9SDXAr7C7omwQhf/7E4sDBRMq335U8UkEmQ3rLNzNzvFg3SxDjj/TCltFu0Ne7o
Xuv7wudsiB+lB9fq7XUeP/bND+34xJHUsJjCO31TahJMQ4JjHP2QyWVYyQloqmMb
NYjqD9aJ9N2aKQJPedoQRL8Fa+8qdA6M0xrb59PU10GyJ7s7ynTq9f9SLGxIgRWr
oKENQmKmcARA7GWDye27gN/P/6I0vnjDbWpQsJ3NEMfSTklEGczvcmhZcXdc7ia/
2fu8wLBk3YE=
=bIM9
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: