Re: aufs3: remove include of linux/fs.h from linux/mm.h

[sfjro@users.sourceforge.net]

Ian Campbell:
> In file included from /=ABPKGBUILDDIR=BB/include/linux/mm.h:23:0,
>                  from /=ABPKGBUILDDIR=BB/include/linux/pid_namespace.h:6,
>                  from /=ABPKGBUILDDIR=BB/include/linux/ptrace.h:9,
>                  from /=ABPKGBUILDDIR=BB/arch/arm64/include/asm/compat.h:26,
>                  from /=ABPKGBUILDDIR=BB/arch/arm64/include/asm/stat.h:23,
>                  from /=ABPKGBUILDDIR=BB/include/linux/stat.h:5,
>                  from /=ABPKGBUILDDIR=BB/include/linux/module.h:10,
>                  from /=ABPKGBUILDDIR=BB/init/main.c:15:
> /=ABPKGBUILDDIR=BB/include/linux/fs.h:1575:64: warning: 'struct kstat' decl=
> ared inside parameter list [enabled by default]
>   int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *);

I will definitely merge and release the patch we made, but I want you to
confirm one thing.
If the problem is the declaraion of kstat only, then declaring it in
fs.h will solve the problem too? Or other similar problems will happen?

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 5c49108..37aac7b 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -39,6 +39,7 @@ struct kiocb;
 struct kobject;
 struct pipe_inode_info;
 struct poll_table_struct;
+struct kstat;
 struct kstatfs;
 struct vm_area_struct;
 struct vfsmount;


J. R. Okajima