[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: aufs3: remove include of linux/fs.h from linux/mm.h



Hello Ian,

Ian Campbell:
> This include is added by aufs3-mmap.patch but causes circular
> dependencies on arm64 as seen with the Debian kernel packages in
	:::
> According to http://article.gmane.org/gmane.linux.ports.arm.kernel/342042
> > The added mm.h->fs.h looks like a mistake, it should not be there, and we=
>  have
> > in the past worked hard to separate mm.h, sched.h and fs.h from one anoth=
> er.

Hmm, I didn't know such history...
Anyway I agree mmap approach in aufs is ugly in the terms of its logic
and looking. And I am afraid converting into macros looks still
bad-looking. Do you think can we do this?
- create a new file mm/aufs_mmap.c
- move the inline funcs to the new file.
- the calling macros are left in mm.h.
- function delarations are added in mm.h.


> Also take the opportunity to wrap the vmr_* macros in ifndef CONFIG_MMU

Is it necessary?
struct vm_regin is defined regardless CONFIG_MMU, isn't it?


J. R. Okajima


Reply to: