On Mon, 2014-04-07 at 15:45 +0200, Raphael Geissert wrote: > Hi, > > On 7 April 2014 03:41, Ben Hutchings <ben@decadent.org.uk> wrote: > > On Mon, 2014-04-07 at 00:35 +0100, Ben Hutchings wrote: > >> 3.2.57-rc1 review patch. If anyone has any objections, please let me know. > > [...] > > --- a/fs/cifs/file.c > > +++ b/fs/cifs/file.c > [...] > > + /* > > + * i + 1 now represents the number of pages we actually used in > > + * the copy phase above. > > + */ > > + npages = min(npages, i + 1); > > I'm having trouble understanding why min() is needed here. It > shouldn't harm either, but I find it confusing. Because in the case where no error occurred, the comment is not true: i == npages and npages have been used. The loop used upstream works, but it seemed a bit silly to use a loop here. Ben. -- Ben Hutchings Sturgeon's Law: Ninety percent of everything is crap.
Attachment:
signature.asc
Description: This is a digitally signed message part