[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#741955: linux: ssize_t casted to unsigned int in fs/cifs/file.c when CONFIG_CIFS_STATS is set



Control: tag -1 wontfix
Control: found -1 linux/3.2.41-1
Control: fixed -1 linux-2.6/3.4.1-1~experimental.1

On Mon, 2014-03-17 at 17:03 +0100, Raphael Geissert wrote:
> Source: linux
> Version: 3.2.54-2
> Severity: minor
> 
> Hi,
> 
> Similar to my previous bug report, I noticed that cifs_iovec_write
> sets the sszie_t 'total_written' to 'rc'[1] but at a later point it
> calls cifs_stats_bytes_written[2] with that <0 value.
> When CONFIG_CIFS_STATS is set, it casts what is passed from
> 'total_written' as an unsigned int and then increases a counter
> (tcon->bytes_written) with it.
> 
> Have not checked what could happen later on.
> 
> This seems to have been fixed in 3.4 with the move to async writes
> with da82f7e755d2808ba726c9b23267d5bb23980e94.
> 
> [1}http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2204
> [2]http://sources.debian.net/src/linux/3.2.54-2/fs/cifs/file.c#L2219

I don't think this is important enough to fix.

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: