Bug#733565: SIX messages per on boot console should be TWO

["Martin K. Petersen" <martin.petersen@oracle.com>]

>>>>> "Ben" == Ben Hutchings <ben@decadent.org.uk> writes:

Ben> I can see that it is emitted by sd_read_cache_type(), which is
Ben> called by sd_revalidate_disk(), and that is apparently now called 3
Ben> times during probe.  Which is quite ridiculous.

We have to discover the basics of the disk before we can create the
gendisk/block device/request queue. And some of the subsequent
parameters we need can't be stored or acted upon until everything has
been set up. So some questions we have to ask several times.


Ben> And I wonder whether this situation (no caching mode page) is
Ben> really serious enough to deserve logging at ERR severity?

I guess we could extend the first_scan logic to cover the error case
scenarios. But it is quite unusual for a device to not implement the
caching mode page...

-- 
Martin K. Petersen	Oracle Linux Engineering