[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#772297: marked as done (linux-kbuild-3.16: bashism in /bin/sh script)

Your message dated Sun, 07 Dec 2014 01:36:37 +0000
with message-id <1417916197.11886.18.camel@decadent.org.uk>
and subject line Re: Bug#772297: linux-kbuild-3.16: bashism in /bin/sh script
has caused the Debian Bug report #772297,
regarding linux-kbuild-3.16: bashism in /bin/sh script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
772297: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772297
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-kbuild-3.16
Severity: normal
Version: 3.16-2
User: debian-release@lists.debian.org
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".

checkbashisms' output:
> possible bashism in ./usr/lib/linux-kbuild-3.16/scripts/setlocalversion
> line 87 (should be 'b = a'):
>		  if [ "`hg log -r . --template '{latesttagdistance}'`" ==
> "1" ]; then


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert

--- End Message ---
--- Begin Message --- 
On Sat, 2014-12-06 at 14:18 +0100, Raphael Geissert wrote:
> Package: linux-kbuild-3.16
> Severity: normal
> Version: 3.16-2
> User: debian-release@lists.debian.org
> Usertags: goal-dash
> 
> Hi,
> 
> I've ran checkbashisms (from the 'devscripts' package) over the whole
> archive and I found that your package has a /bin/sh script that uses a
> "bashism".
> 
> checkbashisms' output:
> > possible bashism in ./usr/lib/linux-kbuild-3.16/scripts/setlocalversion
> > line 87 (should be 'b = a'):
> >		  if [ "`hg log -r . --template '{latesttagdistance}'`" ==
> > "1" ]; then
> 
> 
> Not using bash (or a Debian Policy compliant shell interpreter that doesn't
> provide such an extra feature) as /bin/sh is likely to lead to errors or
> unexpected behaviours. Please be aware that dash is the default /bin/sh.
> 
> Please closely examine the above output and the script, and determine
> what the proper severity of the bug is, and adjust it accordingly. If
> it's important or greater please hurry to get this fixed for jessie.
> 
> Hints about how to fix bashisms can be found at:
> https://wiki.ubuntu.com/DashAsBinSh

This code will only run when building a kernel from a branch maintained
in a Mercurial repository.  As this package is only used to build
external modules, the code is not used and this bug does not matter.

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
                                                         - Carolyn Scheppner

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: