Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted
Retried (slightly earlier build) but instead of doing "ifconfig lo
down" I did a killall of smbd - I then got a system hang within a few
seconds of killing samba. Did you ever get the failure early, before
restarting Samba?
On Fri, Oct 3, 2014 at 12:34 PM, Arthur Marsh
<arthur.marsh@internode.on.net> wrote:
> Hi, I just did:
>
> aplay file-on-server.wav
>
> where the file was several minutes long and I could repeatedly restart the
> samba server if I wanted to, but if I had a crash it happened on the first
> restart of the server.
>
> WAV files have the advantage in testing of a constant and fairly high data
> rate for playback.
>
> Regards,
>
> Arthur.
>
> Steve French wrote, on 04/10/14 02:29:
>
>> I was trying to reproduce this with totem playing a 30 second FLAC
>> file over the network mount but wasn't able to - how did you repro it?
>>
>> On Thu, Oct 2, 2014 at 4:33 AM, Pavel Shilovsky <pshilovsky@samba.org>
>> wrote:
>>>
>>> 2014-10-01 15:34 GMT+04:00 Arthur Marsh <arthur.marsh@internode.on.net>:
>>>>
>>>> I managed to complete a git bisect -- fs/cifs:
>>>>
>>>> git bisect good
>>>> 69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
>>>> commit 69cebd75606f8b9162ad5d0104367370ceabeeba
>>>> Author: Pavel Shilovsky <pshilovsky@samba.org>
>>>> Date: Tue Jun 24 13:42:03 2014 +0400
>>>>
>>>> CIFS: Fix rsize usage in readpages
>>>>
>>>> If a server changes maximum buffer size for read (rsize) requests
>>>> on reconnect we can fail on repeating with a big size buffer on
>>>> -EAGAIN error in readpages. Fix this by checking rsize all the
>>>> time before repeating requests.
>>>>
>>>> Reviewed-by: Shirish Pargaonkar <spargaonkar@suse.com>
>>>> Signed-off-by: Pavel Shilovsky <pshilovsky@samba.org>
>>>> Signed-off-by: Steve French <smfrench@gmail.com>
>>>>
>>>> :040000 040000 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
>>>> 9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M fs
>>>> am64:/usr/src/linux# git bisect log
>>>> git bisect start '--' 'fs/cifs'
>>>> # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
>>>> git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
>>>> # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
>>>> git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
>>>> # bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
>>>> reading from user read
>>>> git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
>>>> # good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
>>>> sending from writepages
>>>> git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
>>>> # good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate
>>>> writing
>>>> from iovec write
>>>> git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
>>>> # good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use
>>>> multicredits
>>>> for SMB 2.1/3 writes
>>>> git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
>>>> # bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage
>>>> in
>>>> readpages
>>>> git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
>>>> # good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
>>>> search from readpages
>>>> git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
>>>> # first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
>>>> rsize usage in readpages
>>>>
>>>> It points to a different "first bad commit" and I apologise if this has
>>>> made
>>>> it more difficult to locate the problem.
>>>>
>>>> I am happy to try more tests to help identify the problem.
>>>
>>>
>>> Thank you for pointing it out!
>>>
>>> I've reproduced and created a patch that fixes the problem to me (see
>>> the attachment). Can you test it, please?
>>>
>>> --
>>> Best regards,
>>> Pavel Shilovsky.
>>
>>
>>
>>
>
--
Thanks,
Steve
Reply to: