On Tue, 2014-09-30 at 10:02 +0200, Rafał Miłecki wrote: > On 30 September 2014 04:15, Ben Hutchings <ben@decadent.org.uk> wrote: > > Move the list of chip type information to a macro in spi-nor.h, but > > leave the definitions of INFO and CAT25_INFO in spi-nor. > > > > In m25p80, define the INFO and CAT25_INFO macros to initialise a > > struct spi_device_id with the name, ignoring the remaining parameters. > > Anyone would consider my idea proposed in 1/5 thread? > > We could simply follow the way Linux-specific platform data works. We > could always use > compatible = "m25p80"; > and then for some rare cases (where JEDEC fails) add something like > model = "at25df321a"; > > Using above way we could use a one single "compatible" in m25p80.c and > avoid this messy share of id_table. You *cannot* define a DT compatible string by reference to out-of-band information about all the chips that has to be updated for each new chip. That is not 'compatible'. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity.
Attachment:
signature.asc
Description: This is a digitally signed message part