[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#727041: marked as done (kernel 3.11 freezes when via velocity interface comes up)

Your message dated Wed, 24 Sep 2014 13:15:38 +0100
with message-id <1411560938.3659.21.camel@decadent.org.uk>
and subject line Re: kernel 3.11-1 freezes when via velocity interface comes up
has caused the Debian Bug report #727041,
regarding kernel 3.11 freezes when via velocity interface comes up
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
727041: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727041
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: src:linux
Version: 3.11.5-1
Severity: grave
Tags: patch

Subject kind of says it all. My system freezes solidly as soon as I ifup the
network interface. Please see e.g.
http://www.spinics.net/lists/netdev/msg251287.html for more details.

Attached patch from mentioned URL fixes the problem for me. I haven't checked
if kernel devs used the same patch, though.

Michael

Description: prevent freeze in velocity based networking
Origin: http://www.spinics.net/lists/netdev/msg251312.html

--- linux-3.11.5.orig/drivers/net/ethernet/via/via-velocity.c
+++ linux-3.11.5/drivers/net/ethernet/via/via-velocity.c
@@ -2172,14 +2172,12 @@ static int velocity_poll(struct napi_str
 	unsigned int rx_done;
 	unsigned long flags;
 
-	spin_lock_irqsave(&vptr->lock, flags);
 	/*
 	 * Do rx and tx twice for performance (taken from the VIA
 	 * out-of-tree driver).
 	 */
-	rx_done = velocity_rx_srv(vptr, budget / 2);
-	velocity_tx_srv(vptr);
-	rx_done += velocity_rx_srv(vptr, budget - rx_done);
+	rx_done = velocity_rx_srv(vptr, budget);
+	spin_lock_irqsave(&vptr->lock, flags);
 	velocity_tx_srv(vptr);
 
 	/* If budget not fully consumed, exit the polling mode */

--- End Message ---
--- Begin Message --- 
Version: 3.13~rc6-1~exp1

On Mon, 2013-10-21 at 21:26 +0200, Michael Meskes wrote:
> Package: src:linux
> Version: 3.11.5-1
> Severity: grave
> Tags: patch
> 
> Subject kind of says it all. My system freezes solidly as soon as I ifup the
> network interface. Please see e.g.
> http://www.spinics.net/lists/netdev/msg251287.html for more details.
> 
> Attached patch from mentioned URL fixes the problem for me. I haven't checked
> if kernel devs used the same patch, though.

This was applied upstream in 3.13-rc3.

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
                                                           - Albert Einstein

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: