[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#747151: marked as done (linux-tools: FTBFS: __u32 and __u64 shoud be used instead of u32 and u64)

Your message dated Wed, 10 Sep 2014 18:09:13 -0300
with message-id <5410BDF9.7090903@linux.vnet.ibm.com>
and subject line linux-tools: error fixed for ppc64 and alpha with linux-tools 3.16-2
has caused the Debian Bug report #747151,
regarding linux-tools: FTBFS: __u32 and __u64 shoud be used instead of u32 and u64
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
747151: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747151
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: linux-tools
Version: 3.14-1
Severity: important
Tags: patch upstream
Usertags: ppc64 alpha

FTBFS on ppc64 and alpha of linux-tools is brought by using u32 and u64.
http://buildd.debian-ports.org/status/package.php?p=linux-tools&suite=sid
http://buildd.debian-ports.org/status/fetch.php?pkg=linux-tools&arch=ppc64&ver=3.14-1&stamp=1399098596
http://buildd.debian-ports.org/status/fetch.php?pkg=linux-tools&arch=alpha&ver=3.14-1&stamp=1398794797

I think that __u32 and __u64 should be used in kernel headers instead of u32 and u64.

Here is a patch and buildlog attached.

Regards,
-- 
Hiroyuki Yamamoto
A75D B285 7050 4BF9 AEDA  91AC 3A10 59C6 5203 04DC

diff -Nurd linux-tools-3.14.orig/include/linux/types.h linux-tools-3.14/include/linux/types.h
--- linux-tools-3.14.orig/include/linux/types.h	2014-03-31 12:40:15.000000000 +0900
+++ linux-tools-3.14/include/linux/types.h	2014-05-06 09:02:25.000000000 +0900
@@ -127,8 +127,8 @@
  * blkcnt_t is the type of the inode's block count.
  */
 #ifdef CONFIG_LBDAF
-typedef u64 sector_t;
-typedef u64 blkcnt_t;
+typedef __u64 sector_t;
+typedef __u64 blkcnt_t;
 #else
 typedef unsigned long sector_t;
 typedef unsigned long blkcnt_t;
@@ -143,9 +143,9 @@
 #endif
 
 #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
-typedef u64 dma_addr_t;
+typedef __u64 dma_addr_t;
 #else
-typedef u32 dma_addr_t;
+typedef __u32 dma_addr_t;
 #endif /* dma_addr_t */
 
 #ifdef __CHECKER__
@@ -159,9 +159,9 @@
 typedef unsigned __bitwise__ oom_flags_t;
 
 #ifdef CONFIG_PHYS_ADDR_T_64BIT
-typedef u64 phys_addr_t;
+typedef __u64 phys_addr_t;
 #else
-typedef u32 phys_addr_t;
+typedef __u32 phys_addr_t;
 #endif
 
 typedef phys_addr_t resource_size_t;

Attachment: linux-tools_3.14-1_ppc64.build.xz
Description: application/xz


--- End Message ---
--- Begin Message --- 
Package: src:linux-tools

This error has been fixed by Ben Hutchings on linux-tools 3.16-2.
An explanation is available in #754213 [1].

For ppc64, the package built successfully [2].

For alpha, the package fails to build, but for another reason/bug.
Another bug should be open for that.

So, this bug can be closed.


alpha error details:
--------------------

  from [3] (which was the same as ppc64 and ppc64el [1]):

	/«PKGBUILDDIR»/include/linux/types.h:148:1: error: unknown type name 'u32'
	 typedef u32 dma_addr_t;
	 ^

  to [4]:
tests/attr.c:67:4: error: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type '__u64' [-Werror=format=] 
	    attr->type, attr->config, fd);
	    ^

Links:

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754213#56
[2] http://buildd.debian-ports.org/status/fetch.php?pkg=linux-tools&arch=ppc64&ver=3.16-2&stamp=1410338208 [3] http://buildd.debian-ports.org/status/fetch.php?pkg=linux-tools&arch=alpha&ver=3.14-1&stamp=1398794797 [4] http://buildd.debian-ports.org/status/fetch.php?pkg=linux-tools&arch=alpha&ver=3.16-2&stamp=1410279955 

--
Mauricio Faria de Oliveira
IBM Linux Technology Center

--- End Message ---
Reply to: