Bug#745731: marked as done (initialize FSTYPE variable)
Your message dated Sun, 31 Aug 2014 07:34:00 +0000
with message-id <E1XNzeC-0007Qg-6p@franck.debian.org>
and subject line Bug#745731: fixed in initramfs-tools 0.116
has caused the Debian Bug report #745731,
regarding initialize FSTYPE variable
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
745731: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745731
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: initialize FSTYPE variable
- From: Helge Deller <deller@gmx.de>
- Date: Thu, 24 Apr 2014 16:30:37 +0200
- Message-id: <5359200D.5060301@gmx.de>
Package: initramfs-tools
Version: 0.115
Severity: normal
Tags: patch
On the hppa platform the fstype program from klibc crashed (details in Bug#745660) which exposed a problem in the
get_fstype() shell function in file scripts/functions.
In this script, fstype is called like this:
eval $(fstype "${FS}" 2> /dev/null)
if [ "$FSTYPE" = "unknown" ] ....
Since fstype crashed and returned nothing in the variable "FSTYPE", FSTYPE stayed empty instead of the value "unknown" and as such no further analysis via blkid was done.
I think it makes sense to pre-initialize FSTYPE to the value "unknown" before calling fstype. That way the program logic will continue correctly if something with the fstype program is wrong.
Attached script fixes this.
Please apply.
Signed-off-by: Helge Deller <deller@gmx.de>
diff -up ./scripts/functions.org ./scripts/functions
--- ./scripts/functions.org 2014-04-24 15:44:54.104641201 +0200
+++ ./scripts/functions 2014-04-24 15:45:35.809485678 +0200
@@ -307,6 +307,7 @@ get_fstype ()
# blkid has a more complete list of file systems,
# but fstype is more robust
+ FSTYPE="unknown"
eval $(fstype "${FS}" 2> /dev/null)
if [ "$FSTYPE" = "unknown" ] && command -v blkid >/dev/null 2>&1 ; then
FSTYPE=$(blkid -o value -s TYPE "${FS}")
--- End Message ---
--- Begin Message ---
Source: initramfs-tools
Source-Version: 0.116
We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 745731@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Prokop <mika@debian.org> (supplier of updated initramfs-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 31 Aug 2014 00:12:42 -0700
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.116
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Michael Prokop <mika@debian.org>
Description:
initramfs-tools - generic modular initramfs generator
Closes: 633582 679436 689558 697368 745731 748805 750360 751143 751488
Changes:
initramfs-tools (0.116) unstable; urgency=medium
.
The "DebConf14" release
.
[ Helge Deller ]
* [cee3e18] get_fstype: initialize FSTYPE variable (Closes: #745731)
.
[ maximilian attems ]
* [7bc24f8] scripts/nfs: fix nfs mount check for possible init symlink
(Closes: #750360)
.
[ Aurelien Jarno ]
* [2e325a2] hook-functions: add support for virtio-mmio
(Closes: #751143)
.
[ Michael Prokop ]
* [4c0338a] Fix hidden dependency issue with btrfs and crc32c. Thanks to
Markus Wanner <markus@bluegap.ch> for the analysis and patch
(Closes: #748805)
* [2290173] Do not spawn shell when panic=... is used. Thanks to Lukas
Anzinger <l.anzinger@gmail.com> for the analysis and patch
(Closes: #751488)
* [0e914d0] Preserve file permissions if root builds the initramfs
images. Thanks to Harald Hoyer <harald@redhat.com> for providing the
patch in dracut (Closes: #633582)
* [39d0561] Support drop_capabilities=... boot option. Thanks to Kees
Cook <kees@debian.org> for the patch (Closes: #679436)
* [3d6fe1e] Support MODULES=dep usage on i2o hardware RAID controller.
Thanks to Stephen Powell <zlinuxman@wowway.com> for the patch
(Closes: #689558)
* [a5126cf] Support usage of partitioned nbd devices with MODULES=dep.
Thanks to Ian Campbell <ijc@hellion.org.uk> for the patch
(Closes: #697368)
* [ebeffcd] Inform user that lsinitramfs doesn't support cpio archives
yet. Thanks to Javier Barroso <javibarroso@gmail.com> for the initial
patch
* [ad7ab64] Bump Standards-Version to 3.9.5
Checksums-Sha1:
2a8865be87ad08dd4922987e9645c9dc94aaaa03 1077 initramfs-tools_0.116.dsc
3ac18ba91f79e9774c880710156cf318b8e7cbab 74508 initramfs-tools_0.116.tar.xz
908f307bd9aa7d33dcc9a5a40166b30e6940f26c 88996 initramfs-tools_0.116_all.deb
Checksums-Sha256:
4ee5a11eb84c2134caf6cedaf4d0ea6404286e7795f044585811a4928043951d 1077 initramfs-tools_0.116.dsc
fe3d8eccc6590323d29480da171b051f13148adbc64d32af906e734556622ed2 74508 initramfs-tools_0.116.tar.xz
61062075502e177ea28e43340950ee64b45d5598b6585f8bf1d38f37bf241154 88996 initramfs-tools_0.116_all.deb
Files:
dc5d69975136f08acf3c735fd6628fd3 88996 utils optional initramfs-tools_0.116_all.deb
411f9c40f3545dfe7408540175e41e5e 1077 utils optional initramfs-tools_0.116.dsc
950b01f36b166fea941a4e9448d1d750 74508 utils optional initramfs-tools_0.116.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlQCzFoACgkQ2N9T+zficugn9QCdEdZRfghx9mUPPXdY3qlNxCGF
qZcAn07eQgmPvNDYsgz68/bplP9dqYXf
=Vo4t
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: