[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFC PATCH 2/8] ppc64el: kernel: add config (work in progress)



On 05/13/2014 07:18 PM, Ben Hutchings wrote:
[...]
+++ b/debian/config/kernelarch-powerpc/config-arch-64-le
[...]
+#. NO HZ
+CONFIG_NO_HZ_IDLE=y

This is set at the top level and does not need to be repeated here.

Ok.

[...]
+#. CELL/PS3
+#. CELL_CPU depends on !CPU_LITTLE_ENDIAN
+# CONFIG_PPC_CELL is not set
+# CONFIG_PPC_PS3 is not set
+# CONFIG_PPC_IBM_CELL_BLADE is not set
+# CONFIG_CPU_FREQ_CBE is not set
+# CONFIG_CBE_CPUFREQ_SPU_GOVERNOR is not set
[...]

So is it even possible to enable these?

Yes (for most), the file arch/powerpc/platforms/Kconfig does 'source'
arch/powerpc/platforms/{cell,ps3}/Kconfig unconditionally.

Those files contain most of those options, and some of them don't
depend on CELL_CPU/PPC_CELL.  But it's indeed possible to reduce them
(I intend to more closely verify all other options listed, later):

- PPC_CELL: doesn't depend on CELL_CPU (hm.. makes sense -- it's an
  /optimization/ option, as it's described)

- PPC_PS3: doesn't depend on CELL_CPU (likewise) neither PPC_CELL.

- PPC_IBM_CELL_BLADE: doesn't depend on CELL_CPU/PPC_CELL.

- CPU_FREQ_CBE (ok, remove): depends on PPC_CELL
- CBE_CPUFREQ_SPU_GOVERNOR (ok, remove): depends on PPC_CELL
  (SPU_FS -> PPC_CELL)


It seems like the enabling of these should be moved from
debian/config/kernelarch-powerpc/config-arch-64 to
debian/config/kernelarch-powerpc/config-arch-64-be (and then
debian/config/{powerpc,ppc64}/defines updated to include it).

Ok.

Thanks!

--
Mauricio Faria de Oliveira
IBM Linux Technology Center


Reply to: