[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#724644: marked as done (initramfs-tools: Parsing of ip= option is brittle)

Your message dated Mon, 04 Nov 2013 09:49:12 +0000
with message-id <E1VdGmW-0004S8-0W@franck.debian.org>
and subject line Bug#724644: fixed in initramfs-tools 0.115
has caused the Debian Bug report #724644,
regarding initramfs-tools: Parsing of ip= option is brittle
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
724644: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724644
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.113
Severity: normal

Dearest Maintainer,

The configure_networking() function in scripts/functions fails
to parse an "ip=" kernel option if it has more than one parameter
following the device name.  For example:

  ip=client-ip:server-ip:gw-ip:netmask:hostname:device:autoconf

works just fine, however,

  ip=client-ip:server-ip:gw-ip:netmask:hostname:device:autoconf:dns0:dns1

does not, and that happens to be the format described in
  https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

A one character change to configure_networking() will make it immune to
any number of parameters following the device name:

--- functions   2013-09-25 00:39:49.000000000 -0700
+++ functions-better    2013-09-25 00:40:20.000000000 -0700
@@ -396,7 +396,7 @@
                        # grab device entry from ip option
                        NEW_DEVICE=${IP#*:*:*:*:*:*}
                        if [ "${NEW_DEVICE}" != "${IP}" ]; then
-                               NEW_DEVICE=${NEW_DEVICE%:*}
+                               NEW_DEVICE=${NEW_DEVICE%%:*}
                        else
                                # wrong parse, possibly only a partial string
                                NEW_DEVICE=

In other words:  remove the *longest* suffix beginning with ":", rather
than the shortest.

-mm

-- Package-specific info:
-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.10-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages initramfs-tools depends on:
ii  cpio               2.11+dfsg-1
ii  klibc-utils        2.0.1-3.1
ii  kmod               9-3
ii  module-init-tools  9-3
ii  udev               204-4

Versions of packages initramfs-tools recommends:
ii  busybox  1:1.20.0-9

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.115

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 724644@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Prokop <mika@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 04 Nov 2013 10:10:23 +0100
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.115
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Michael Prokop <mika@debian.org>
Description: 
 initramfs-tools - generic modular initramfs generator
Closes: 724554 724644 726957
Changes: 
 initramfs-tools (0.115) unstable; urgency=low
 .
   [ Nikolaus Schulz ]
   * [736200b] hooks/resume: fix validation of $RESUME in config file
     (Closes: #724554)
 .
   [ Matto Marjanovic ]
   * [b4fc5de] hooks/function: More solide ip= option parsing (Closes:
     #724644)
 .
   [ maximilian attems ]
   * [9f7bb9c] init: support UUID for resume bootarg
 .
   [ Michael Prokop ]
   * [9da5948] Add ohci-pci to base modules (Closes: #726957)
Checksums-Sha1: 
 435c56ec1ccb043ae016355215f791d6aabcde30 1089 initramfs-tools_0.115.dsc
 7981bd800fc50e194401acda95f9640999534387 86890 initramfs-tools_0.115.tar.gz
 43ce4d00ef67837ae26ddaa9e452fa499b6123b1 88082 initramfs-tools_0.115_all.deb
Checksums-Sha256: 
 df1b4a3e1ea8d863051e5356609a22efb077fcd9ee3d6715f45d768572695aa2 1089 initramfs-tools_0.115.dsc
 1fd08da52500651439f0abb0a5c9365adb50555f8cdefdaafc75458bad0d4ce6 86890 initramfs-tools_0.115.tar.gz
 95a6d739f9bbaf61e779b4e2f5ca845b049131b654001906172c4e22025d01d9 88082 initramfs-tools_0.115_all.deb
Files: 
 af6fe09f6a6ca64fc8e217259ba3b519 1089 utils optional initramfs-tools_0.115.dsc
 132a00d6387afbb5c56eecaa09da1182 86890 utils optional initramfs-tools_0.115.tar.gz
 84ff4c119c9ab37bfd554efef2fa2b88 88082 utils optional initramfs-tools_0.115_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlJ3ZxYACgkQ2N9T+zficuhXIwCeIx+eiiGC/ygwWG3D5VZQaOBK
Z7cAnjLXy6aAqCGV2WJEuqXinoxD59AK
=F5Yo
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: