Bug#696632: initramfs-tools: Patches to clean up /run handling for jessie
On Mon, 24 Dec 2012, Roger Leigh wrote:
> 1) Migration of /run to the rootfs is mandatory, i.e. /run is required to
> be present on the rootfs. This will be the case for all jessie installs
> and upgrades (unlike wheezy, which needed the special-case logic to
> manually migrate udev/mdadm state).
While I agree on the patch himself, I don't see an urge for that.
There is no real cost in keeping that for now and axing once Jessie is
released. I like to keep one interval inbetween as it helps users..
(I know it is broken to often, but here there is no argument for the
rush).
> 2) Create /run/initramfs if needed. This might also need fixing for wheezy,
> since I can't see where it's created (if at all), so opening the debug
> file might actually be broken at present.
Hmmm, init does it line 29, so not needed.
> >From 13d1e4b4bf8dc163ae488016aa2da6a11b284f57 Mon Sep 17 00:00:00 2001
> From: Roger Leigh <rleigh@debian.org>
> Date: Mon, 24 Dec 2012 13:36:53 +0000
> Subject: [PATCH 1/2] init: Always migrate /run to the rootfs
>
> ---
> init | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/init b/init
> index cb832ff..929de29 100755
> --- a/init
> +++ b/init
> @@ -228,20 +228,8 @@ maybe_break bottom
> run_scripts /scripts/init-bottom
> [ "$quiet" != "y" ] && log_end_msg
>
> -# Preserve information on old systems without /run on the rootfs
> -if [ -d ${rootmnt}/run ]; then
> - mount -n -o move /run ${rootmnt}/run
> -else
> - # The initramfs udev database must be migrated:
> - if [ -d /run/udev ] && [ ! -d /dev/.udev ]; then
> - mv /run/udev /dev/.udev
> - fi
> - # The initramfs debug info must be migrated:
> - if [ -d /run/initramfs ] && [ ! -d /dev/.initramfs ]; then
> - mv /run/initramfs /dev/.initramfs
> - fi
> - umount /run
> -fi
> +# Move /run to the root
> +mount -n -o move /run ${rootmnt}/run
>
> validate_init() {
> checktarget="${1}"
> --
As I said happy about that patch, but unlikely for now, so ok
for a downgrade to wishlist for the moment beeing?
Reviewed-by: maximilian attems <max@stro.at>
> >From 29046070b93b4c97456ca9a8aadfbba0a54dc380 Mon Sep 17 00:00:00 2001
> From: Roger Leigh <rleigh@debian.org>
> Date: Mon, 24 Dec 2012 13:38:40 +0000
> Subject: [PATCH 2/2] init: Create /run/initramfs
Nack.
Thank you.
--
maks
Reply to: