[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#704933: [stable] fbcon: fix locking harder



On Sat, 2013-04-13 at 03:28 +0400, Stepan Golosunov wrote:
[...]
> The relevant changes in 3.2.40 (
> fb: rework locking to fix lock ordering on takeover,
> fb: Yet another band-aid for fixing lockdep mess;
> described in
> http://lists.freedesktop.org/archives/dri-devel/2013-January/033976.html)
> appear to be missing from debian/changelog.

Yes, maybe I should make it more clear that not all commits are listed
in the Debian changelog (there are just too many).  I try to list
everything that looks like it could be release-critical - data loss,
security vulnerabilities, and major regressions.

> And the missing fix (fbcon: fix locking harder) was discussed in
> http://lists.freedesktop.org/archives/dri-devel/2013-January/033980.html.
> 
> Any of the two attached patches makes 3.2.41-2 bootable here.

I think we should move forward rather than back.  So that's:

commit 054430e773c9a1e26f38e30156eff02dedfffc17
Author: Dave Airlie <airlied@gmail.com>
Date:   Fri Jan 25 11:38:56 2013 +1000

    fbcon: fix locking harder

You've shown that it can be cleanly cherry-picked and works for 3.2.y.
It looks like the relevant code didn't change between 3.0 and 3.2, so it
should be good for all 3.x.y branches.  3.8.y already has it.

(I'm a bit disappointed that after the discussion in
<http://thread.gmane.org/gmane.linux.kernel/1429173> no-one spotted the
missing fix when the other two were reviewed for stable.  Oh well.)

Ben.

-- 
Ben Hutchings
The first rule of tautology club is the first rule of tautology club.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: