initramfs-tools: resume from disk broken with LVM swap

[Nikolaus Schulz <microschulz@web.de>]

Ping?

On Fri, Sep 27, 2013 at 01:05:33PM +0200, Nikolaus Schulz wrote:
> On Fri, Sep 27, 2013 at 11:52:53AM +0200, maximilian attems wrote:
> > $ zcat /boot/initrd.img-$(uname -r) |
> >     cpio -i --to-stdout --quiet conf/conf.d/resume
> > RESUME=UUID=2806fd03-ddfe-43b6-a339-b4bb051c20d4

This does not find my swap partition upon resume.

> > diff --git a/init b/init
> > index cb832ff..7990977 100755
> > --- a/init
> > +++ b/init
> > @@ -133,6 +133,10 @@ for x in $(cat /proc/cmdline); do
> >  		;;
> >  	resume=*)
> >  		RESUME="${x#resume=}"
> > +		case $RESUME in
> > +	        UUID=*)
> > +			RESUME="/dev/disk/by-uuid/${RESUME#UUID=}"
> > +		esac
> >  		;;
> >  	resume_offset=*)
> >  		resume_offset="${x#resume_offset=}"
> > -- 
> > 1.8.4.rc3

This patch is inconsistent with the resume hook, isn't it?
The hook adds a plain RESUME=UUID=... while here you use the
/dev/disk/by-uuid/ symlink.

I have tested using that symlink in /etc/initramfs-tools/conf.d/resume:

  RESUME=/dev/disk/by-uuid/2806fd03-ddfe-43b6-a339-b4bb051c20d4

And it does not find the swap partition on resume.  I guess the same
applies to the resume=* kernel arg as well.

I don't know if that's correct, but as I have already said, the fix for
bug #568877 in base-installer suggests that using the UUID for swap
partitions on LVM is broken.  This has also been discussed three years
ago in initramfs-tools bug #576490.

> Uhm, I don't have resume=* specified on my kernel cmdline.  I never had,
> on the machine in question at least, I just verified w/ etckeeper.  To
> be honest, this makes me scratching my head a bit. :)  Isn't that
> supported?

It is my understanding that it is.

> PS. It seems that debbugs/lists.debian.org eats my emails.  Again. :/
> Need to look into that.

(Switched to alternate email address for now.)

Nikolaus