Bug#714974: [PATCH] jfs: avoid misuse of cookie value of 2
On 08/15/2013 02:09 AM, Christian Kujau wrote:
> On Wed, 14 Aug 2013 at 21:29, Christian Kujau wrote:
>
>> On Wed, 14 Aug 2013 at 22:54, Dave Kleikamp wrote:
>>> It looks like the problem is that jfs was using a cookie value of 2 for
>>> a real directory entry, where NFSv4 expect 2 to represent "..". This
>>> patch has so far only been lightly tested.
>>
>> Hm, a first compile of 3.11-rc5 errors out with:
>>
>> CC [M] fs/jfs/jfs_dtree.o
>> /usr/local/src/linux-git/fs/jfs/jfs_dtree.c: In function ‘add_index’:
>> /usr/local/src/linux-git/fs/jfs/jfs_dtree.c:493:13: error: invalid storage class for function ‘free_index’
> [...]
>>
>> I'll run mrproper and try again...
>
> This did not help, but adding a closing bracket did, in fs/jfs/jfs_dtree.c:354
>
> if (jfs_ip->next_index < 3) {
> jfs_ip->next_index = 3;
> }
> -----^
>
> This compiled and booted and now I can run find(1) over that whole NFS
> share, without any "readdir loop" messages and with unique inode numbers,
> yay!
My bad. That's what happens when you clean up the patch after you test
it. I intended to remove the opening bracket when I removed a warning.
> Tested-by: Christian Kujau <lists@nerdbynature.de>
Thanks. After sleeping on it, I'm contemplating a simpler patch. I'll
keep you up to date.
>
> Thanks!
> Christian.
>
Reply to: