[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#623377: rpcbind: Please include upstart support in the rpcbind package



Hey Bastian,

On Tue, Aug 13, 2013 at 08:56:54AM +0200, Bastian Blank wrote:
> On Tue, Aug 13, 2013 at 01:15:31AM +0200, Steve Langasek wrote:
> > +   * Fix to look directly in /run instead of via the /var/run symlink.

> Where is the bug report for this?

This is mentioned in bug #719357.

> >  case "$1" in
> >      start)
> > +        if init_is_upstart; then
> > +            exit 1
> > +        fi

> Where is this documented and why does it need to be done in every case?

Documented generally in Debian policy 9.11.1.  This *could* be implemented
by exiting non-zero in all cases, but it's nicer from a policy perspective
to return 0 when asking to stop a service that is not managed by upstart
(because from the init script's perspective, it is "not running").

> > --- a/debian/postinst	2011-12-10 11:36:35 +0000
> > +++ b/debian/postinst	2013-08-12 22:46:00 +0000
> > @@ -10,6 +10,9 @@
> >  			ln -s /run/rpcbind.pid /run/sendsigs.omit.d/rpcbind
> >  		fi
> >  	fi
> > +	if dpkg --compare-versions "$2" lt "0.2.0-8.1"; then
> > +		update-rc.d -f rpcbind remove
> > +	fi

> How does this not trash local modifications?

sysv-rc in jessie does not support non-dependency-based boot, so there are
no local modifications to the links that need to be (or can be) supported
anyway.  Are you concerned about the file-rc case?

I'm not attached to this bit, but I discussed it with Luk and he said he
would prefer the stale links be cleaned up.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Attachment: signature.asc
Description: Digital signature


Reply to: