Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51
- To: Octavio Alvarez <alvarezp@alvarezp.com>
- Cc: Lan Tianyu <tianyu.lan@intel.com>, Frank Schäfer <fschaefer.oss@googlemail.com>, Lan Tianyu <lantianyu1986@gmail.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <677472@bugs.debian.org>, Ben Hutchings <ben@decadent.org.uk>, <linux-usb@vger.kernel.org>, Frank Schäfer <schaefer.frank@gmx.net>
- Subject: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51
- From: Alan Stern <stern@rowland.harvard.edu>
- Date: Wed, 19 Dec 2012 11:57:00 -0500 (EST)
- Message-id: <[🔎] Pine.LNX.4.44L0.1212191153090.1580-100000@iolanthe.rowland.org>
- Reply-to: Alan Stern <stern@rowland.harvard.edu>, 677472@bugs.debian.org
- In-reply-to: <[🔎] op.wpkn45wk6g6bxc@alvarezp-samsung>
On Wed, 19 Dec 2012, Octavio Alvarez wrote:
> On Wed, 19 Dec 2012 07:29:23 -0800, Alan Stern <stern@rowland.harvard.edu>
> wrote:
> >> + ohci_dbg(ohci, "marked as bad wakeup.\n");
> >
> > I'd prefer the message to be something more like "enabled nVidia/SiS
> > wakeup quirk".
>
> To me, the stupid end-user, both messages are useless. I don't know
You, the stupid end-user, would not see this message at all under
normal circumstances. It uses the ohci_dbg macro and therefore will
not appear unless your kernel is built with CONFIG_USB_DEBUG enabled.
> that that means or implies. I would go with:
> "Disabled OHCI wakeup (USB) due to faulty controller (no-wakeup.txt)"
>
> and have a file named no-wakeup.txt under Documentation with this:
>
> "
> Users have reported OHCI misbehavior consisting on false wakeups right
> after suspend to RAM on some OHCI controllers, particularly from nVIDIA
> and SiS. For those controllers, wakeups has been disabled.
>
> The system will not be able to wake up the system from suspend
> to RAM from an OHCI (USB) device.
>
> To see the list of affected controllers do:
>
> grep -B 3 ohci_quirk_bad_wakeup linux-pm/drivers/usb/host/ohci-pci.c
>
> Bug is tracked at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677472
> "
It wouldn't hurt to include a URL for the bug report in a comment.
Alan Stern
Reply to: