[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#680762: [stable 2.6.36+] lirc_sir: make device registration work



On Aug 5, 2012, at 3:52 PM, Ben Hutchings <ben@decadent.org.uk> wrote:

> On Wed, 2012-08-01 at 15:51 +0200, Stefan Lippers-Hollmann wrote:
>> Hi
>> 
>> Please consider adding "[media] lirc_sir: make device registration 
>> work" to stable:
>> 
>> <formletter>
>> 
>> This probably needs to get acked by the subsystem maintainer.
>> 
>> </formletter>
> 
> Mauro, Jarod?

Yup, should be good to go, sorry.

Acked-by: Jarod Wilson <jarod@redhat.com>



>> commit 4b71ca6bce8fab3d08c61bf330e781f957934ae1
>> Author: Jarod Wilson <jarod@redhat.com>
>> Date:   Mon Jun 4 13:05:24 2012 -0300
>> 
>>    [media] lirc_sir: make device registration work
> [...]
>> This commit fixes loading the lirc_sir module, which previously 
>> wouldn't load/ be usable at all (since its introduction in v2.6.36).
>> 
>> serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
>> smsc_superio_flat(): fir: 0x230, sir: 0x2f8, dma: 03, irq: 3, mode: 0x0e
>> smsc_ircc_present: can't get sir_base of 0x2f8
>> […]
>> lirc_dev: IR Remote Control driver registered, major 251
>> lirc_sir: module is from the staging directory, the quality is unknown, you have been warned.
>> lirc_register_driver: dev pointer not filled in!
>> lirc_sir: init_chrdev() failed.
> [...]
> 
> It looks like lirc_register_driver() really ought to be renamed...
> 
> Ben.
> 
> -- 
> Ben Hutchings
> Computers are not intelligent.    They only think they are.

Reply to: