[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#664767: Brcmsmac driver woes, possible regression?



found 664767 linux-2.6/3.2.12-1
tags 664767 - moreinfo
quit

Camaleón wrote:

> Anyway, after having loaded kernel 3.2.19 (with the set of patches
> applied) for all the weekend and until today, I've experienced NO
> reconnects nor random connection downs which means the wireless link
> runs stable and at least it's usable here :-)

Nice.  Let's call that a success.

Kernel team: here is a list of the patches[*] Camaleón applied:

  6b1a89afbf97 brcm80211: smac: drop "40MHz intolerant" flag from HT
               capability info
  c261bdf8acad brcm80211: smac: indicate severe problems to Mac80211
  0bf1f883fd0a brcm80211: smac: removed MPC related code
  4412953061de brcm80211: smac: removed MPC related variables
  28237002e726 brcm80211: smac: removed down-on-watchdog MPC functionality
  43ac09722f8e brcm80211: smac: removed down-on-rf-kill functionality
  a8bc4917ed6b brcm80211: smac: bugfix for tx mute in brcms_b_init()
  c6c44893c864 brcm80211: smac: fixed inconsistency in transmit mute
  2646c46d5679 brcm80211: smac: modified Mac80211 callback interface
  dc460127898c brcm80211: smac: mute transmit on ops_start
  1525662ac280 brcm80211: smac: changed check to confirm STA only support
  b7eec4233c34 brcm80211: smac: replace own access category definitions
               with mac80211 enum
  e9ca530a7b18 brcm80211: smac: don't modify sta parameters when adding sta
  8906c43cb160 brcm80211: smac: fix channel frequency
  02a588a2e3b9 brcm80211: smac: combine promiscuous mode functionality
  be667669ec01 brcm80211: smac: added support for mac80211 filter flags
 [d3f311349add brcm80211: fix usage of set tx power] --- unrelated, my mistake
  aa1f2f0a3218 brcm80211: smac: precendence bug in wlc_phy_attach()
  1570e53c14ff brcm80211: smac: fix unintended fallthru in
               wlc_phy_radio_init_2057()
  137dabed34a1 brcm80211: smac: remove smatch warnings from brcmsmac code
  2b0a53d51b5f brcm80211: smac: only print block-ack timeout message at
               trace level
  6b8da423315b brcm80211: smac: do not use US as fallback regulatory hint
  94a2ca311cf4 brcm80211: smac: only provide valid regulatory hint

It's not clear to me which of these addresses the memory corruption
and random reconnects Camaleón was experiencing.  I think we should
take them all.  (It's basically a backport of brcmsmac changes to
date, minus the switch to BCMA.)

Commit 2b0a53d51b5f (only print block-ack timeout message at trace
level) addresses the distracting log noise from bug#674430.

Commits c261bdf8acad (reset mac80211 too when resetting) and
2646c46d5679 (disable rx on ops_stop) sound useful but their
descriptions don't mention the symptoms.  8906c43cb160 (fix channel
216 frequency) and 1570e53c14ff (don't treat 2057 radio rev 5 like rev
7) also look like obviously good fixes.  Likewise for 137dabed34a1
(avoid NULL pointer dereference, especially when memory is short)
though it wouldn't have caused Camaleón's trouble.

Commits 6b1a89afbf97 (drop "40MHz intolerant" flag from HT capability
info), 6b8da423315b (do not use US as fallback regulatory hint), and
94a2ca311cf4 (only pass valid regulatory hints to cfg80211) affect the
channel used and might explain why the connection is more stable.

Thanks,
Jonathan

[*] http://bugs.debian.org/664767#99



Reply to: