Bug#515201: linux-image: sata drive connected via marvell controller crashes
Hi Eduardo,
egross@bol.com.br wrote:
> Anyway, now only the second command is needed in an archive in the
> directory modprobe.d in order to all work well - boot does not fail
> and the external drive connected to sata controller works perfectly.
> So, the main command seems to be "options ahci marvell_enable=1".
Please test the attached patch with the marvell_enable parameter
temporarily removed (instructions are at [1]).
(If the patch works correctly, the external drive will not be
visible and the kernel log will contain some useful information.)
Thanks,
Jonathan
[1] http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official
or the corresponding page from the debian-kernel-handbook package
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Fri, 5 Feb 2010 16:26:35 +0100
Subject: [libata] pata_marvell: CONFIG_AHCI is really CONFIG_SATA_AHCI
commit cb6643e1c38b6bd5c1594f0a45d8cf6943a6f934 upstream.
The marvell driver comtains a fallback to ahci for the sata ports
which is incorrectly checked as CONFIG_AHCI while the only AHCI config
item is actually called SATA_AHCI (which also sounds sensible
considering it's a fallback for the sata ports).
Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
drivers/ata/pata_marvell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
index 2096fb737f82..e4589fc52290 100644
--- a/drivers/ata/pata_marvell.c
+++ b/drivers/ata/pata_marvell.c
@@ -147,7 +147,7 @@ static int marvell_init_one (struct pci_dev *pdev, const struct pci_device_id *i
if (pdev->device == 0x6101)
ppi[1] = &ata_dummy_port_info;
-#if defined(CONFIG_AHCI) || defined(CONFIG_AHCI_MODULE)
+#if defined(CONFIG_SATA_AHCI) || defined(CONFIG_SATA_AHCI_MODULE)
if (!marvell_pata_active(pdev)) {
printk(KERN_INFO DRV_NAME ": PATA port not active, deferring to AHCI driver.\n");
return -ENODEV;
--
1.7.10.2
Reply to: