Control: tag -1 fixed-upstream patch moreinfo On Thu, 2012-11-15 at 21:29 +0800, Adam Lee wrote: > Package: src:linux > Version: 3.2.32-1 > Severity: important > > Hi, all > > As $subject, system hangs when halting, it's a e1000e driver bug. Please > backport from upstream to fix it. > > Steps to reproduce: > 1, # for i in /sys/bus/pci/devices/*/power/control; do echo "auto" > "$i"; done > 2, shutdown or reboot > > Another way to reproduce, which makes this bug important: > 1, install laptop-mode-tools > 2, start laptop-mode-tools service > 3, shutdown or reboot > > This bug is fixed in kernel 3.3 > https://bugzilla.kernel.org/show_bug.cgi?id=36132 > > Just FYI, > https://bbs.archlinux.org/viewtopic.php?id=113985 [...] But it's not clear how it was fixed... Can you test whether the attached patch works, following the instructions at <http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official>? Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by stupidity.
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Thu, 15 Dec 2011 20:59:23 +0100
Subject: PM / Sleep: Simplify generic system suspend callbacks
commit 8ca6d9bcc8d33c592c0855b4b1481bc723ac7e85 upstream.
The pm_runtime_suspended() check in __pm_generic_call() doesn't
really help and may cause problems to happen, because in some cases
the system suspend callbacks need to be called even if the given
device has been suspended by runtime PM. For example, if the device
generally supports remote wakeup and is not enabled to wake up
the system from sleep, it should be prevented from generating wakeup
signals during system suspend and that has to be done by the
suspend callbacks that the pm_runtime_suspended() check prevents from
being executed.
Similarly, it may not be a good idea to unconditionally change
the runtime PM status of the device to 'active' in
__pm_generic_resume(), because the driver may want to leave the
device in the 'suspended' state, depending on what happened to it
before the system suspend and whether or not it is enabled to
wake up the system.
For the above reasons, remove the pm_runtime_suspended()
check from __pm_generic_call() and remove the code changing the
device's runtime PM status from __pm_generic_resume().
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/base/power/generic_ops.c | 24 ++++++------------------
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/drivers/base/power/generic_ops.c b/drivers/base/power/generic_ops.c
index 265a0ee..1b878b955 100644
--- a/drivers/base/power/generic_ops.c
+++ b/drivers/base/power/generic_ops.c
@@ -97,16 +97,16 @@ int pm_generic_prepare(struct device *dev)
* @event: PM transition of the system under way.
* @bool: Whether or not this is the "noirq" stage.
*
- * If the device has not been suspended at run time, execute the
- * suspend/freeze/poweroff/thaw callback provided by its driver, if defined, and
- * return its error code. Otherwise, return zero.
+ * Execute the suspend/freeze/poweroff/thaw callback provided by the driver of
+ * @dev, if defined, and return its error code. Return 0 if the callback is
+ * not present.
*/
static int __pm_generic_call(struct device *dev, int event, bool noirq)
{
const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
int (*callback)(struct device *);
- if (!pm || pm_runtime_suspended(dev))
+ if (!pm)
return 0;
switch (event) {
@@ -217,14 +217,12 @@ EXPORT_SYMBOL_GPL(pm_generic_thaw);
* @bool: Whether or not this is the "noirq" stage.
*
* Execute the resume/resotre callback provided by the @dev's driver, if
- * defined. If it returns 0, change the device's runtime PM status to 'active'.
- * Return the callback's error code.
+ * defined, and return its error code. Return 0 if the callback is not present.
*/
static int __pm_generic_resume(struct device *dev, int event, bool noirq)
{
const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
int (*callback)(struct device *);
- int ret;
if (!pm)
return 0;
@@ -241,17 +239,7 @@ static int __pm_generic_resume(struct device *dev, int event, bool noirq)
break;
}
- if (!callback)
- return 0;
-
- ret = callback(dev);
- if (!ret && !noirq && pm_runtime_enabled(dev)) {
- pm_runtime_disable(dev);
- pm_runtime_set_active(dev);
- pm_runtime_enable(dev);
- }
-
- return ret;
+ return callback ? callback(dev) : 0;
}
/**
Attachment:
signature.asc
Description: This is a digitally signed message part