[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#690071: ecryptfs: corrupted files on a disk full event



I had a short conversation with one of the upstream developers, Tyler
Hicks. It seems that there are still two other patches required: 
"For completeness, I wanted to point out two more patches which should
be added to the list I gave in comment 20. 821f749 introduced a
regression and these two patches are needed to fix the regression:

64e6651 eCryptfs: Call lower ->flush() from ecryptfs_flush()
7149f25 eCryptfs: Write out all dirty pages just before releasing the
lower file

Actually, 7149f25 is the only one required but I recommend 64e6651, as
well."

https://bugs.launchpad.net/ubuntu/+source/ecryptfs-utils/+bug/957843/comments/22


The IRC chat: 
<glatzor> tyhicks, hello
<tyhicks> glatzor: Hi
* mwhudson hat die Verbindung getrennt (Ping timeout: 246 seconds)
<glatzor> tyhicks, I run an ecryptfs protected home dir on my debian
wheezy system and run into the corrupted files on disk full error
<glatzor> tyhicks, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=
+%09690071
* dholbach hat die Verbindung getrennt (Read error: Connection reset by
peer)
<glatzor> tyhicks, you mentioned that some patches to fix this problem
have been applied in ubuntu. but I still get the problem with the
patches applied
<glatzor> tyhicks, are there any further patches missing?
* dholbach (~daniel@ubuntu/member/dholbach) hat #ubuntu-devel betreten
<tyhicks> glatzor: You applied the 3 patches mentioned at the bottom of
that bug?
<glatzor> tyhicks, right.
<glatzor> tyhicks, with the applied patches the command to fill up the
disk failed correctly by a disk full error. I used dd if=/dev/zero
of=disk-full bs=1M
<glatzor> tyhicks, but without the patches the dd command tries to write
for ever
* babyface__ hat die Verbindung getrennt (Quit: Ex-Chat)
<tyhicks> glatzor: With the patches applied, it sounds like things are
working correctly. Why do you think there is still a problem?
* TJ- (tj@yes.iam.tj) hat #ubuntu-devel betreten
* mvo hat die Verbindung getrennt (Quit: Ex-Chat)
<glatzor> tyhicks, because I still get files of zero size in
$HOME/.Private/ that cause problems
* mvo (~egon@p5B09B69A.dip.t-dialin.net) hat #ubuntu-devel betreten
* tsdgeos hat die Verbindung getrennt (Remote host closed the
connection)
<tyhicks> glatzor: FYI, see
https://bugs.launchpad.net/ubuntu/+source/ecryptfs-utils/+bug/957843/comments/22
<ubottu> Launchpad bug 957843 in eCryptfs "files in eCryptFS Private
directory get corrupted" [High,Fix released]
<yhicks> glatzor: Those two extra patches don't fix the problem that
you're seeing, but they're needed if you carry the other three patches
<glatzor> tyhicks, Is it ok if I add this conversation to the bug? I
will try with the other two patches
<tyhicks> glatzor: Sure
<tyhicks> glatzor: I'm going to have to step away shortly. If you're
sure that you're still seing zero length files, please file an upstream
eCryptfs bug at https://bugs.launchpad.net/ecryptfs/+filebug and I'll
take a look at it tomorrow.


Am Dienstag, den 09.10.2012, 12:33 -0700 schrieb Jonathan Nieder: 
> tags 690071 + upstream patch moreinfo
> quit
> 
> Hi Sebastian,
> 
> Sebastian Heinlein wrote:
> 
> > After a running into a full disk event with my ecrypts encrypted home directory
> [...]
> > I see a lot of random broken files on my system:
> [...]
> > https://bugs.launchpad.net/ubuntu/+source/ecryptfs-utils/+bug/957843
> 
> Please test the attached patches against a 3.2.y kernel, for example
> using the following instructions:
> 
>  0. prerequisites
> 
> 	apt-get install git build-essential
> 
>  1. get the kernel history, if you don't already have it
> 
> 	git clone \
> 	  git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
>  2. fetch point releases
> 
> 	cd linux
> 	git remote add stable \
> 	  git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> 	git fetch stable
> 
>  3. configure, build, test
> 
> 	git checkout stable/linux-3.2.y
> 	cp /boot/config-$(uname -r) .config; # current configuration
> 	scripts/config --disable DEBUG_INFO
> 	make localmodconfig; # optional: minimize configuration
> 	make deb-pkg; # optionally with -j<num> for parallel build
> 	dpkg -i ../<name of package>; # as root
> 	reboot
> 	... test test test ...
> 
>     Hopefully it reproduces the bug, so
> 
>  4. try the patches
> 
> 	cd linux
> 	git am -3sc $(ls -1 /path/to/patches/0*)
> 	make deb-pkg; # maybe with -j4
> 	dpkg -i ../<name of package>; # as root
> 	reboot
> 	... test test test ...
> 
> Hope that helps,
> Jonathan


Reply to: