[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#664461: [squeeze] atl1c: AR8152: "transmit queue 0 timed out" and network is unusable until reset

On Thu, 2012-07-05 at 00:23 +0000, Huang, Xiong wrote:
> Hi Jonathan
>     I review the code porting, everything look ok, but vlan,
> adapter->vlgrp is used for packet receive, but the code of :
> if (unlikely(adapter->vlgrp && vlan_tx_tag_present(skb))) {
>         in file atl1c_main.c is used for tx, this might be an issue.

The test of adapter->vlgrp was removed upstream by:

commit eab6d18d20fc5b5ba04a7e7fcd6f357197870e51
Author: Jesse Gross <jesse@nicira.com>
Date:   Wed Oct 20 13:56:03 2010 +0000

    vlan: Don't check for vlan group before vlan_tx_tag_present.
    Many (but not all) drivers check to see whether there is a vlan
    group configured before using a tag stored in the skb.  There's
    not much point in this check since it just throws away data that
    should only be present in the expected circumstances.  However,
    it will soon be legal and expected to get a vlan tag when no
    vlan group is configured, so remove this check from all drivers
    to avoid dropping the tags.
    Signed-off-by: Jesse Gross <jesse@nicira.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

I believe this means it is unnecessary but harmless in 2.6.32.


Ben Hutchings
73.46% of all statistics are made up.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: