[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#677157: marked as done (initramfs-tools: root=/dev/nfs mostly useless due to BOOT=local being defined in initramfs.conf)

Your message dated Mon, 09 Jul 2012 17:32:29 +0000
with message-id <E1SoHoz-0001rC-QE@franck.debian.org>
and subject line Bug#677157: fixed in initramfs-tools 0.107
has caused the Debian Bug report #677157,
regarding initramfs-tools: root=/dev/nfs mostly useless due to BOOT=local being defined in initramfs.conf
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
677157: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677157
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools
Version: 0.106
Severity: normal
Tags: patch


Specifying root=/dev/nfs doesn't really do anything without also either 
specifying boot=nfs or changing BOOT= in initramfs.conf:

  /dev/nfs)
        [ -z "${BOOT}" ] && BOOT=nfs
        ;;

At which point, you could just as well not specify root=/dev/nfs at all.

This breaks the historical method for network booting with nfsroot with the 
kernel arguments:

  ip=dhcp root=/dev/nfs

I guess the check to make sure BOOT wasn't already set was changed in order to 
fix putting boot= anywhere in the boot commandline:

  http://bugs.debian.org/453294

But it seems to me the correct thing to do in that case would be to specify 
boot=live after root=/dev/nfs... since the order of the argument processing 
matters, rather than preferring the result of one argument over another.

Alternately/Additionally, why is BOOT=local defined in initramfs.conf at all? 
What about only setting BOOT=local if $BOOT is undefined, after all the 
argument processing is done:

diff --git a/conf/initramfs.conf b/conf/initramfs.conf
index abc231b..995d455 100644
--- a/conf/initramfs.conf
+++ b/conf/initramfs.conf
@@ -53,7 +53,7 @@ COMPRESS=gzip
 # nfs - Boot using an NFS drive as the root of the drive.
 #

-BOOT=local
+#BOOT=local

 #
 # DEVICE: ...
diff --git a/init b/init
index cbd22e2..7e54a73 100755
--- a/init
+++ b/init
@@ -186,6 +186,11 @@ for x in $(cat /proc/cmdline); do
        esac
 done

+if [ -z "${BOOT}" ]; then
+       # Default to BOOT=local if no boot script defined.
+       BOOT=local
+fi
+
 if [ -n "${noresume}" ]; then
        export noresume
        unset resume


live well,
  vagrant

--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.107

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 677157@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Conrad <adconrad@0c3.net> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 09 Jul 2012 11:07:21 -0600
Source: initramfs-tools
Binary: initramfs-tools
Architecture: all source
Version: 0.107
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Adam Conrad <adconrad@0c3.net>
Closes: 638068 659752 677157
Launchpad-Bugs-Fixed: 889584
Description: 
 initramfs-tools - generic modular initramfs generator
Changes: 
 initramfs-tools (0.107) unstable; urgency=low
 .
   [ Michal Suchanek ]
   * initramfs-tools: copy_exec quote ${src}
   * initramfs-tools: copy_exec add pattern for nonoptimized multiarch
     libraries (Closes: #659752)
 .
   [ Vagrant Cascadian ]
   * initramfs-tools Don't override root=/dev/nfs by BOOT=local config
     (Closes: #677157)
 .
   [ Adam Conrad ]
   * hooks/klibc: Make us play more nicely with busybox and static bin/sh
     (Closes: #638068)
   * Kernel versions aren't (necessarily) package versions, so redirect
     the whining from dpkg --compare-versions to /dev/null to avoid scary
     (and incorrect) warnings. (LP: #889584)
Checksums-Sha1: 
 84ee3fa3f463dd442c79f9cc6139f436134358fe 1052 initramfs-tools_0.107.dsc
 1e258bc0d20423ab700814b25e33ffedb662a52e 84681 initramfs-tools_0.107.tar.gz
 b077905498d5ec60fafce1dfb486def4f5025e70 90350 initramfs-tools_0.107_all.deb
Checksums-Sha256: 
 ffd4b8d0a6995ee65258a0c5b4abe7ef3f1c6c4244147cebc0e4bcfcc624cf69 1052 initramfs-tools_0.107.dsc
 354c37fe550b174ac219b6386ec5ea829ca1de66cc2b8e94fea96b3d77c8b2f3 84681 initramfs-tools_0.107.tar.gz
 964fc74473057eb9c46b61e4bc9c1359525c004773fcca872160a021057af6c6 90350 initramfs-tools_0.107_all.deb
Files: 
 e9c790e9703e3ed63497fee29160faec 1052 utils optional initramfs-tools_0.107.dsc
 8e8c39bbdf51c85a3045c35c15084baa 84681 utils optional initramfs-tools_0.107.tar.gz
 d9e11e8b225849d41f7a9aecee189f90 90350 utils optional initramfs-tools_0.107_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk/7EpcACgkQvjztR8bOoMnMlACg+aSQwhmjAn9bBXkMqR4uzltE
imEAoJZJkdVtnUa4YXFHCxZetSJksq0q
=Ptgg
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: