Bug#661696: [2.6.33.y] drm/i915: wrong fifo size due to uncareful refactoring which results in an xserver crash at 800x600
Hi Jonathan,
yes, it works for me!
Regards,
Lukas
On Sun, Jun 24, 2012 at 6:39 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> forwarded 661696 https://bugzilla.kernel.org/show_bug.cgi?id=42839
> quit
>
> (cc-ing Stefan Bader since he maintains the linux-2.6.32.y-drm33.z tree)
> Hi again,
>
> Lukas Anzinger wrote[1]:
>
>> During a refactoring of the i915 driver a regression has been introduced
> [e70236a8d3d0]
>> For some chipsets the wrong fifo size is determined which results in
>> lot's of pixel errors when starting the xserver and choosing 800x600
>> as a resolution. If another resolution is used (eg. 1024x768 or
>> 1280x1024), I don't encounter this problem.
>
> [...]
> Jonathan Nieder wrote:
>> Lukas Anzinger wrote:
>
>>> looks good to me.
>>
>> Do you mean that the patch looks good or that you've tried applying it
>> and the behavior was bad before and good afterward?
>
> Ping. Have you tested this patch?
>
> From: Adam Jackson <ajax@redhat.com>
> Date: Fri, 16 Apr 2010 18:20:57 -0400
> Subject: drm/i915: Attempt to fix watermark setup on 85x (v2)
>
> commit 8f4695ed1c9e068772bcce4cd4ff03f88d57a008 upstream.
>
> IS_MOBILE() catches 85x, so we'd always try to use the 9xx FIFO sizing;
> since there's an explicit 85x version, this seems wrong.
>
> v2: Handle 830m correctly too.
>
> Signed-off-by: Adam Jackson <ajax@redhat.com>
> Reviewed-by: Eric Anholt <eric@anholt.net>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
>
> In suspense,
> Jonathan
>
> [1] http://bugs.debian.org/661696
Reply to: