On Tue, 2012-06-19 at 20:46 -0500, Jonathan Nieder wrote: > (+cc: devel@driverdev) > Hi Ben, > > Ben Hutchings wrote: > > > ZSMALLOC is tristate, but the code has no MODULE_LICENSE and since it > > depends on GPL-only symbols it cannot be loaded as a module. This in > > turn breaks zram which now depends on it. I assume it's meant to be > > Dual BSD/GPL like the other z-stuff. > > Yep, the opening comment in the file says so. > > > There is also no module_exit, which will make it impossible to unload. > > Add the appropriate module_init and module_exit declarations suggested > > by comments. > > > > Reported-by: Christian Ohm <chr.ohm@gmx.net> > > I sent a similar patch + fixup last week[*]. Yours has a clearer > description. The only other difference aside from reordering lines is > that I marked zs_init as __init and zs_exit as __exit. Ah, but you made the mistake of marking it 'RFC'. :-) > [...] > > This is compile-tested only. > > Someone using zram tested last week's patch (which is almost > identical) against 3.4.y and let me know it worked by private email, > but I don't have permission to name that person. > > So for what it's worth, > Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Thanks. Ben. -- Ben Hutchings It is easier to change the specification to fit the program than vice versa.
Attachment:
signature.asc
Description: This is a digitally signed message part