[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#673391: Revised patches for be2net



Ben,
  I am attaching the remaining to patches:
68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy 
e5686ad netdev: make net_device_ops const

Please apply them too.

Thanks,
Sarvesh

-----Original Message-----
From: Ben Hutchings [mailto:ben@decadent.org.uk] 
Sent: Sunday, May 27, 2012 5:27 AM
To: Bandi,Sarveshwar; 673391@bugs.debian.org
Subject: Re: Bug#673391: Revised patches for be2net

On Fri, 2012-05-25 at 09:30 -0700, Sarveshwar.Bandi@Emulex.Com wrote:
> Ben,
>   I am attaching the revised patches as per your comments. I was not 
> sure how to handle patches (4 of them) which involved changes to other 
> drivers too. I intend to open separate bugs for each of them and send 
> them. Hope that is ok.

No, there's no need to open more bugs.

> I have also taken care of your comment  to not change the return value 
> in ndo_vlan_rx_[add/kill]_vid 
> (8e586137e6b63af1e881b328466ab5ffbe562510). The patches also contain 
> the upstream commit id thanks to your git-format-patch-for-backport 
> script.

Thanks.

So the remaining 4 changes are:

68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const

It's absolutely fine to apply just the parts of these that affect your driver, as in your original series.

8e58613 net: make vlan ndo_vlan_rx_[add/kill]_vid return error value

This should not be applied at all, as we don't want to change the kernel API.

786f528 ethtool: Null-terminate filename passed to ethtool_ops::flash_device

I think this is an important bug fix (well I would do :-) so I'll apply it and also propose to David Miller that it goes into stable updates.

Ben.

--
Ben Hutchings
The obvious mathematical breakthrough [to break modern encryption] would be development of an easy way to factor large prime numbers. - Bill Gates

Attachment: 0001-sweep-the-floors-and-convert-some-.get_drvinfo-routi.patch
Description: 0001-sweep-the-floors-and-convert-some-.get_drvinfo-routi.patch

Attachment: 0027-netdev-make-net_device_ops-const.patch
Description: 0027-netdev-make-net_device_ops-const.patch


Reply to: