On Fri, 2012-05-18 at 10:39 -0700, Sarveshwar.Bandi@Emulex.Com wrote:
> I am attaching the patches (61) to update the be2net driver. All
> patches have already been accepted and applied to net-next. I have
> applied and tested these patches on debian
> linux-source-3.2_3.2.17-1_all.deb source package. Please apply them
> to you source tree.
1/61 'sweep the floors and convert some .get_drvinfo routines to
strlcpy' (commit 68aad78c5023b8aa82da99b47f9d8cf40e8ca453 upstream)
applied to many drivers; please note in the patch header that you've
filtered it to just be2net.
Same for 27/61 'netdev: make net_device_ops const'.
17/61 'net: make vlan ndo_vlan_rx_[add/kill]_vid return error
value' (commit 8e586137e6b63af1e881b328466ab5ffbe562510 upstream)
is wrong:
CC [M] drivers/net/ethernet/emulex/benet/be_main.o
drivers/net/ethernet/emulex/benet/be_main.c:3186:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/emulex/benet/be_main.c:3186:2: warning: (near initialization for ‘be_netdev_ops.ndo_vlan_rx_add_vid’) [enabled by default]
drivers/net/ethernet/emulex/benet/be_main.c:3187:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/emulex/benet/be_main.c:3187:2: warning: (near initialization for ‘be_netdev_ops.ndo_vlan_rx_kill_vid’) [enabled by default]
You can't go changing the types of netdev operations in a backport.
You'll also need to adjust 24/61 'be2net: fix
be_vlan_add/rem_vid' (commit 80817cbf5ac13da76f3ee2b9259f26c09b385e84
upstream) to apply without the type change.
31/61 'ethtool: Null-terminate filename passed to
ethtool_ops::flash_device' (commit
786f528119722f564a22ad953411374e06116333 upstream) is wrong; by
filtering to only drivers/net/emulex/benet/ you've lost the essential
part of it! Actually that fix should maybe go to stable, not just
Debian.
61/61 'Updating driver version number' isn't upstream as you claimed,
but I don't have any objection as long as you explain it in the patch
header.
Please can you use the script 'git-format-patch-for-backport'
<http://anonscm.debian.org/viewvc/kernel/people/benh/git-format-patch-for-backport?revision=HEAD&view=co> to generate patches with the upstream commit IDs included. This is a wrapper for 'git format-patch' and takes all the same arguments.
Ben.
--
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
- Carolyn Scheppner
Attachment:
signature.asc
Description: This is a digitally signed message part