Bug#670462: linux-2.6: Support new armhf kernel variant for Versatile Express (vexpress)

[Vagrant Cascadian <vagrant@freegeek.org>]

On Mon, May 07, 2012 at 08:38:27AM +0200, Arnaud Patard wrote:
> Vagrant Cascadian <vagrant@freegeek.org> writes:
> > only in patch2:
> > unchanged:
> > --- linux-2.6-3.2.16.orig/debian/config/armhf/config.vexpress
> > +++ linux-2.6-3.2.16/debian/config/armhf/config.vexpress
> > @@ -0,0 +1,54 @@
> > +##
> > +## file: arch/arm/Kconfig
> > +##
> > +## choice: ARM system type
> > +CONFIG_ARCH_VEXPRESS=y
> > +## end choice
> > +
> > +## arch/arm/mach-vexpress/Kconfig
> > +CONFIG_ARCH_VEXPRESS_CA9X4=y
> > +
> > +CONFIG_LOG_BUF_SHIFT=14
> 
> any reason for this change ?

It was in the default vexpress config shipped upstream in
arch/arm/configs/vexpress_defconfig. it is also present in a couple of the
debian/config/armel/ configs. Honestly, no idea what it actually does, so I'm
not attached to keeping it if it still works without it.


> > +CONFIG_OPROFILE=m
> > +
> > +CONFIG_SMP=y
> > +CONFIG_VMSPLIT_2G=y
> > +CONFIG_HOTPLUG_CPU=y
> > +
> > +CONFIG_ZBOOT_ROM_TEXT=0x0
> > +CONFIG_ZBOOT_ROM_BSS=0x0
> > +
> > +CONFIG_NEON=y
> > +
> > +
> > +CONFIG_MTD=m
> 
> hm. why is it still enabled ? from what I understand, qemu vexpress doesn't
> simulate the flash peripheral. If you want to support something else
> than qemu, you're missing some drivers I guess. If you want to support
> only qemu vexpress emulation, maybe it worthes to be mentionned in the
> description ?

Again, it was part of the vexpress default config shipped in the upstream 
kernel (although i switched it from enabled to a module).

 
> > +CONFIG_MTD_CONCAT=m
> > +CONFIG_MTD_PARTITIONS=m
> > +CONFIG_MTD_CMDLINE_PARTS=m
> > +CONFIG_MTD_CHAR=m
> > +CONFIG_MTD_BLOCK=m
> > +CONFIG_MTD_CFI=m
> > +CONFIG_MTD_CFI_INTELEXT=m
> > +CONFIG_MTD_CFI_AMDSTD=m
> > +CONFIG_MTD_ARM_INTEGRATOR=m
> 
> fwiw, doesn't exist anymore. physmap should be used now.

Same story there, too.

 
> Nevertheless, I've built tested this configuration and it worked in Qemu
> as expected. I'll add that once we agree on the configuration.

Great! Thanks for taking the time to review it.

I'll defer to others on matters of why to enable or disble particular options; 
I just grabbed the default config, tested that it works in qemu, and then 
trimmed out what seemed to be duplicated in other parts of debian/config/.


> Also, do you intend to add support for it into the debian-installer too ?

I think that would be usefuul, and can put some time into that. Though it 
seemed like the first steep would be to get a working kernel shipped.


live well,
  vagrant