On Mon, 2012-04-09 at 09:51 +0200, Christian Felsing wrote:
> Package: linux-2.6
> Version: 2.6.32-41squeeze2
> Severity: normal
>
>
> After restart of Asterisk following line appeared in syslog:
>
> [79419.383260] ------------[ cut here ]------------
> [79419.383274] WARNING: at /tmp/buildd/linux-2.6-2.6.32/debian/build/source_i386_openvz/drivers/usb/serial/usb-serial.c:440 serial_unthrottle+0x44/0x5a [usbserial]()
[...]
It looks like this was fixed upstream by:
commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304
Author: Andrew McGregor <andrew.mcgregor@alliedtelesis.co.nz>
Date: Mon Jun 13 11:31:31 2011 +1200
tty: fix "IRQ45: nobody cared"
The symptom mentioned here (unexpected IRQ) is different but I think the
underlying bug is the same.
Can you test the attached patch against the stable kernel? Instructions
for this can be found at:
<http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official>.
Ben.
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
From: Andrew McGregor <andrew.mcgregor@alliedtelesis.co.nz> Date: Mon, 13 Jun 2011 11:31:31 +1200 Subject: [PATCH] tty: fix "IRQ45: nobody cared" commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304 upstream. Unthrottling the TTY during close ends up enabling interrupts on a device not on the active list, which will never have the interrupts cleared. Doctor, it hurts when I do this. >>> On 6/2/2011 at 01:56 AM, in message <20110601145608.3e586e16@bob.linux.org.uk>, Alan Cox <alan@linux.intel.com> wrote: > On Wed, 01 Jun 2011 10:34:07 +1200 > "andrew mcgregor" <andrew.mcgregor@alliedtelesis.co.nz> wrote: > > The LKML message > > http://kerneltrap.org/mailarchive/linux-kernel/2010/2/25/4541847 from > > February doesn't seem to have been resolved since. We struck the > > issue, and the patch below (against 2.6.32) fixes it. Should I > > supply a patch against 3.0.0rc? > > I think that would be sensible. I don't actually see how you hit it as > the IRQ ought to be masked by then but it's certainly wrong for n_tty > to be calling into check_unthrottle at that point. > > So yes please send a patch with a suitable Signed-off-by: line to > linux-serial and cc GregKH <greg@kroah.com> as well. > > Alan Signed-off-by: Andrew McGregor <andrew.mcgregor@alliedtelesis.co.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> [bwh: Backported to 2.6.32 again: change filename] --- --- a/drivers/char/n_tty.c +++ b/drivers/char/n_tty.c @@ -178,7 +178,6 @@ static void reset_buffer_flags(struct tty_struct *tty) tty->canon_head = tty->canon_data = tty->erasing = 0; memset(&tty->read_flags, 0, sizeof tty->read_flags); n_tty_set_room(tty); - check_unthrottle(tty); } /** @@ -1574,6 +1573,7 @@ static int n_tty_open(struct tty_struct *tty) return -ENOMEM; } reset_buffer_flags(tty); + tty_unthrottle(tty); tty->column = 0; n_tty_set_termios(tty, NULL); tty->minimum_to_wake = 1;
Attachment:
signature.asc
Description: This is a digitally signed message part