On Wed, 2012-04-04 at 11:28 -0500, Jonathan Nieder wrote: [...] > Using an assertion (WARN_ONCE) means that Len thinks calls to > floppy_disable_hlt are a Bad Thing in some sense, presumably because > of their effect on power consumption. So this might be a real bug or > just an overly aggressive warning. The fix is > > commit f6365201d8a2 > Author: Len Brown <len.brown@intel.com> > Date: Thu Mar 29 14:49:17 2012 -0700 > > x86: Remove the ancient and deprecated disable_hlt() and enable_hlt() facility > > and is not part of "master" yet. I don't understand how anyone > thought applying the warning without the fix could be a good idea. If this kluge had been optional in the floppy driver then warning users that enable it might have made sense. But it seems completely useless to warn everyone using the floppy driver. I'm just amused that this it took 3 stable releases for someone to complain about this. Shows how many floppies are being used today. I don't think this explains the original report that 'Floppy drive is unusable' though. [...] > Ben, I think we should take this patch. Do you think it's a candidate > for gregkh's stable tree? It's already on its way there. Ben. -- Ben Hutchings Larkinson's Law: All laws are basically false.
Attachment:
signature.asc
Description: This is a digitally signed message part