[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#665420: pata_jmicron hdd/dvd/cdrom drives not detected, gave up waiting for root device



tags 665420 + upstream
# regression
severity 665420 important
found 665420 linux-2.6/3.3-1~experimental.1
forwarded 665420 http://thread.gmane.org/gmane.linux.kernel/1269210/focus=1269495 http://thread.gmane.org/gmane.linux.kernel/1271264
tags 665420 + patch
quit

janek wrote:

> I cannot see drives and can't boot system
[...]
> The same behavior with linux-image-3.3.0-trunk-686-pae and my own kernel
> compilation (linux-3.3.tar.bz2; make deb-pkg with config from
> linux-image-3.3.0-trunk-686-pae)
[...]
>> From	Romain Francoise <>
>> Subject	Re: Linux 3.3 release
>> Date	Mon, 19 Mar 2012 10:28:32 +0100
>>
>> There seems to be a regression in the final release compared to -rc7,
>> specifically this commit:
>>
>>> Matthew Garrett (1):
>>>       PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled
>>
>> causes an early kernel panic on my machine (Intel DP67BG). Reverting the
>> change fixes it.

Thanks.

Kernel team: since there is no upstream fix yet, I think we should
revert 4949be168 (PCI: ignore pre-1.1 ASPM quirking when ASPM is
disabled, 2012-03-06) for now.

Hope that helps,
Jonathan
Index: debian/changelog
===================================================================
--- debian/changelog	(revision 18881)
+++ debian/changelog	(working copy)
@@ -6,6 +6,10 @@
   [ Uwe Kleine-König ]
   * [rt] bump version to 3.2.12-rt22
 
+  [ Jonathan Nieder ]
+  * Revert "PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled",
+    included in stable update 3.2.12 (Closes: #665420)
+
  -- Ben Hutchings <ben@decadent.org.uk>  Wed, 21 Mar 2012 03:15:13 +0000
 
 linux-2.6 (3.2.12-1) unstable; urgency=high
Index: debian/patches/series/base
===================================================================
--- debian/patches/series/base	(revision 18881)
+++ debian/patches/series/base	(working copy)
@@ -86,3 +86,4 @@
 + bugfix/all/tcp-fix-syncookie-regression.patch
 + bugfix/all/ipv6-don-t-dev_hold-dev-in-ip6_mc_find_dev_rcu.patch
 + bugfix/all/kbuild-do-not-check-for-ancient-modutils-tools.patch
++ bugfix/all/Revert-PCI-ignore-pre-1.1-ASPM-quirking-when-ASPM-is.patch
Index: debian/patches/bugfix/all/Revert-PCI-ignore-pre-1.1-ASPM-quirking-when-ASPM-is.patch
===================================================================
--- debian/patches/bugfix/all/Revert-PCI-ignore-pre-1.1-ASPM-quirking-when-ASPM-is.patch	(revision 0)
+++ debian/patches/bugfix/all/Revert-PCI-ignore-pre-1.1-ASPM-quirking-when-ASPM-is.patch	(working copy)
@@ -0,0 +1,32 @@
+From: Jonathan Nieder <jrnieder@gmail.com>
+Date: Fri, 23 Mar 2012 20:46:45 -0500
+Subject: Revert "PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled"
+
+This reverts commit f043ddb60c84ea64a23b755004572afe922e653c (upstream
+commit 4949be16822e92a18ea0cc1616319926628092ee) as it is causing boot
+failures.
+
+Reported-by: Romain Francoise <romain@orebokech.com>
+Reported-by: Chris Holland <bandidoirlandes@gmail.com>
+Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
+---
+ drivers/pci/pcie/aspm.c |    3 ---
+ 1 file changed, 3 deletions(-)
+
+diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
+index 24f049e73952..1cfbf228fbb1 100644
+--- a/drivers/pci/pcie/aspm.c
++++ b/drivers/pci/pcie/aspm.c
+@@ -500,9 +500,6 @@ static int pcie_aspm_sanity_check(struct pci_dev *pdev)
+ 	int pos;
+ 	u32 reg32;
+ 
+-	if (aspm_disabled)
+-		return 0;
+-
+ 	/*
+ 	 * Some functions in a slot might not all be PCIe functions,
+ 	 * very strange. Disable ASPM for the whole slot
+-- 
+1.7.10.rc1
+

Reply to: