[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#655387: [PATCH] usb: cdc_ether: Ignore bogus union descriptor for RNDIS devices

On Wed, 11 Jan 2012 09:44:03 +0100, Oliver Neukum wrote:
Am Mittwoch, 11. Januar 2012, 09:36:56 schrieb Iker Salmón San Millán:
2012/1/11 Bjørn Mork <bjorn@mork.no>

> if you have the patience to test yet-another-patch.
> Bjørn

Yes, I do, but:

2012/1/11 Oliver Neukum said:
>You are trying something subtle here. Stop doing that. Use a dedicated flag
>or a clearly named goto.

All this is obviusly over my programming skills so, just tell me what to do
and i'll do it.

Bjørn's basic approach is good. But he's to subtle in the consequence
of detecting
an RNDIS device with a broken union descriptor.

I'd like something that is pretty close to:

if (test_for_broken_descriptor())
	goto handle_broken_rndis;


Is it really a broken union descriptor?
There is all information but the original cdc_ether code can only handle union descriptor which starts with 0.
That is something e.g. the Windows driver can handle.

Reply to: