Ben Hutchings wrote: > It's fairly obvious that the default module lists for Linux should be > moved to the linux-2.6 source package. We can do that right now and use > relative paths to include them in the per-architecture/flavour lists. > However the #include <foo-modules> syntax would then be unused. It > seems like it would be better to allow overriding the directory that is > searched. Yes, or search in both places. > Also, kernel-wedge has a single package template shared between Linux > and kFreeBSD. Is this necessary? (I don't know how the installer > selects module packages to use.) Should the Linux package template also > be moved to the linux-2.6 source package? It does so based on Priority, plus some special cases. There would not be much duplication involved in copying the package-list into linux-2.6, since kfreebsd only uses 8 entries from that so far. And beyond the odd module udeb name that might be hardcoded into d-i and needs to be the same across linux and kfreebsd, there seems to be only benefit in untangling the two kernels' package-list files. > I was considering changing kernel-wedge to support a KW_DEFCONFIG_DIR > variable, similar to the KW_CONFIG_DIR variable, that would affect where > all of these files are looked for. The (untested) change is pretty > small: > > diff --git a/README b/README > index 6bf5b87..df52199 100644 > --- a/README > +++ b/README > @@ -84,7 +84,12 @@ Suppose we want a different set of modules in the speakup flavored kernel. > Then create a modules/<arch>-<flavor>/nic-modules instead, it will be used > by preference. One udeb will be created for each modules list file, > containing the listed modules. The names of the files should match the > -names of the various modules listed in /usr/share/kernel-wedge/package-list. > +names of the various modules listed in the package-list file in the > +default-configuration directory. > + > +The default-configuration directory is either specified by the > +environment variable $KW_DEFCONFIG_DIR or else defaults to > +/usr/share/kernel-wedge. I don't see why this is necessary. If /usr/share/kernel-wedge/package-list does not exist or is empty, kernel-wedge should still use the package-list file from the linux-2.6 source package, and that's the right place to list all the module udebs. -- see shy jo
Attachment:
signature.asc
Description: Digital signature