[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Add 3.0-rc7-rt0 patch set



On Thu, 2011-07-21 at 16:25 +0200, Uwe Kleine-König wrote:
> It's currently enabled and build tested for amd64/amd64 and armel/versatile.
> 
> The rt patches applied as provided by Thomas Gleixner with just one
> exception: linux-3.0-rc7.patch. That contains the diff of Linus Torvald's
> tree at the time of the rt release since the v3.0-rc7 tag. Two changes were
> already in the debian tree, namely
> 
> 	bugfix/arm/ixp4xx-build-breakage.patch
> 	bugfix/mips/mips-i8259-use-struct-syscore_ops-instead-of-sysdevs.patch
> 
> ---
> Some things I'm unsure about:
>  - should I really add the series file and the disabled patches?
>    (upside: the rt patches dir is nearly identical with the upstream
>    patch queue.)
>  - which platforms to enable the rt featureset for?

Let's start with amd64/amd64, and any other flavours you know people are
interested in.  I'm not convinced armel/versatile is useful other than
as proof that it compiles for ARM...

[...]
> diff --git a/changelog b/changelog
> index 7bf0add..45cebaa 100644
> --- a/changelog
> +++ b/changelog
> @@ -17,6 +17,10 @@ linux-2.6 (3.0.0~rc7-1~experimental.1) UNRELEASED; urgency=low
>    [ Arnaud Patard ]
>    * Merge ixp4xx build fix and enable ixp4xx back
>  
> +  [ Uwe Kleine-König ]
> +  * add 3.0-rc7-rt0 patch set, currently enabled for amd/amd and

amd64/amd64

> +    armel/versatile
> +
>   -- maximilian attems <maks@debian.org>  Tue, 05 Jul 2011 14:25:29 +0200
>  
>  linux-2.6 (3.0.0~rc6-1~experimental.1) experimental; urgency=low
[...]
> diff --git a/config/defines b/config/defines
> index 9f65ad3..27cac2b 100644
> --- a/config/defines
> +++ b/config/defines
> @@ -22,6 +22,7 @@ arches:
>  compiler: gcc-4.4
>  featuresets:
>   none
> + rt
>  
>  [description]
>  part-long-up: This kernel is not suitable for SMP (multi-processor,
> @@ -38,6 +39,9 @@ type: plain
>  gcc-4.4: gcc-4.4
>  gcc-4.5: gcc-4.5
>  
> +[featureset-rt]
> +enabled: true
> +

You are inserting this in the middle of the 'relations' section!  Add it
at the bottom of the file.

>  # initramfs-generators
>  initramfs-fallback: linux-initramfs-tool
>  initramfs-tools: initramfs-tools (>= 0.99)
> diff --git a/config/featureset-rt/config b/config/featureset-rt/config
> new file mode 100644
> index 0000000..8136f16
> --- /dev/null
> +++ b/config/featureset-rt/config
> @@ -0,0 +1,5 @@
> +# CONFIG_PREEMPT_VOLUNTARY is not set
> +CONFIG_PREEMPT_RT_FULL=y
> +CONFIG_SCHED_TRACER=y
> +CONFIG_MISSED_TIMER_OFFSETS_HIST=y
> +CONFIG_WAKEUP_LATENCY_HIST=y

I notice that you leave Xen (and other pvops) support enabled.  I don't
think this makes sense, as virtualisation will add back the latency and
jitter that RT is trying to avoid.

> diff --git a/config/featureset-rt/defines b/config/featureset-rt/defines
> new file mode 100644
> index 0000000..caf2baf
> --- /dev/null
> +++ b/config/featureset-rt/defines
> @@ -0,0 +1,7 @@
> +[abi]
> +ignore-changes: *
> +
> +[description]
> +part-long-rt: This kernel includes the PREEMPT_RT patch set

This should be a whole sentence, ending in a full stop (period).

> +part-short-rt: PREEMPT_RT
> +parts: rt
> [... removed many patches here ...]
[...]

It would be nice if you would add a script to refresh the patch series,
similar to:

debian/patches/bugfix/all/stable/gen-patch
debian/patches/features/all/aufs2/gen-patch
debian/patches/features/all/vserver/gen-patch

Ben.

-- 
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: