Bug#648996: linux-2.6: FTBFS [m68k] in modpost: "strlen" [iscsi_target_mod.ko] undefined! (and others)

[Jonathan Nieder <jrnieder@gmail.com>]

Thorsten Glaser wrote:

> ERROR: "strlen" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "strcpy" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!

Hm, see also [1].  I guess there might be a useless use of strncat
here.  I wonder if there's a way to ask GCC not to do this kind of
magic when the functions that would entail calling are not available.

[1] http://thread.gmane.org/gmane.linux.kernel/680193/focus=680351

I don't see linux/string.h doing anything that could help us, but if
it did, I guess something like the following might be needed, too.

diff --git i/drivers/target/iscsi/iscsi_target_tpg.c w/drivers/target/iscsi/iscsi_target_tpg.c
index d4cf2cd25c44..0d5b64105919 100644
--- i/drivers/target/iscsi/iscsi_target_tpg.c
+++ w/drivers/target/iscsi/iscsi_target_tpg.c
@@ -18,6 +18,7 @@
  * GNU General Public License for more details.
  ******************************************************************************/
 
+#include <linux/string.h>
 #include <target/target_core_base.h>
 #include <target/target_core_transport.h>
 #include <target/target_core_fabric_ops.h>