[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] module: Enable dynamic debugging regardless of taint

* Rusty Russell (rusty@rustcorp.com.au) wrote:
> On Tue, 01 Nov 2011 03:59:33 +0000, Ben Hutchings <ben@decadent.org.uk> wrote:
> > Dynamic debugging is currently disabled for tainted modules, except
> > for TAINT_CRAP.  This prevents use of dynamic debugging for
> > out-of-tree modules now that they are also tainted.
> > 
> > This condition was apparently intended to avoid a crash if a force-
> > loaded module has an incompatible definition of dynamic debug
> > structures.  However, a administrator that forces us to load a module
> > is claiming that it *is* compatible even though it fails our version
> > checks.  If they are mistaken, there are any number of ways the module
> > could crash the system.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Thanks, applied, unless Mathieu objects...

I'm OK with that. We should probably note in the changelog the
side-effect of now supporting dynamic debugging of proprietary drivers.
If we start doing this for dynamic debugging, I'd be tempted to do it
for tracepoints and static jump labels too, since at least tracepoints
would not be the only "offender" (from an end-user point of view)
causing crashes on incompatible module load.


Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

> Cheers,
> Rusty.

Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.

Reply to: