On 27/09/11 20:27, Jeff Layton wrote:
On Mon, 26 Sep 2011 14:31:32 -0400 Jeff Layton<jlayton@redhat.com> wrote:Not sure what happened here. Looks like the "freeze phase" of the suspend worked. My inclination is to think that this is not due to my patch. What might be helpful is to try suspending without NFS being mounted. If that doesn't work either, then maybe back out the patch and try again without any NFS mounts.Yeah, after looking over the code I really think the instant wakeup thing is an unrelated problem. This patchset is really intended to fix the problem where the freezer is unable to freeze tasks that are stuck waiting on replies from NFS and CIFS servers. If you aren't seeing these sorts of errors when trying to suspend, then this is probably a different problem: https://bugzilla.redhat.com/show_bug.cgi?id=717735#c0 It would be nice to have some successful tests with this set though before I propose it, but that might not be possible given the general fragility of the userspace suspend code :-/
I'm testing away. I think you're right about the problems now being userspace.I feel that the "hang after thaw" problems I'm seeing are caused by krb5 - it seems to like to get itself into a situation where it has no krb5 ticket so it can't access my home directory which prevents the unlock window popping up so it can't get my password and ask for a new krb5 ticket.
If I log on on another screen or serial terminal then the unlock dialogue pops up.
I'm going to continue testing today but so far my feeling is that the patch works as advertised - nfs4 shares no longer prevent suspend from working.
John would you be able to test the things I mentioned in my prior reply? In particular, seeing whether you're able to suspend consistently without nfs mounts and without those patches in place? If that doesn't work either, then I'll be inclined to think that this is unrelated.
So far (I'll confirm tomorrow) 1. I can suspend without nfs mounts 2. I can suspend with nfs mounts if they are not my home directory3. suspending with nfs mounts of the home directory using echo mem >/sys/power/state works 4. suspending with nfs mounts of the home directory using pm-suspend usualy works 5. suspending with nfs mounts of the home directory using gnome shutdown/suspend menu item often hangs.
The problems are much more visible on my klunky old Optiplex GX270 systems (2.6GHz P4) than my nice new Optiplex 390 (Core I3).