[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#630593: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets



On Thu, Sep 15, 2011 at 3:41 PM, Bastien ROUCARIES
<roucaries.bastien@gmail.com> wrote:
> On Thu, Sep 15, 2011 at 2:41 PM, Leopold Palomo-Avellaneda
> <leo@alaxarxa.net> wrote:
>> Hi again,
>>
>> sorry for the noise and my mistake. The patch...
>>
>> there's a bug in the parport module that have been reported (in another
>> places) some time ago [1]. Also, this bug was reported at Redhat [2], but
>> nobody follow the report and it was closed.

Moreover they are more detail about this bug here you should contact
davbid campell

http://lists.infradead.org/pipermail/linux-parport/2004-March/000048.html

Bastien

>> As Adam Baker said [1] :
>>
>> <quote>
>> A long time ago (~ 10 years), Intel produced a chipset that
>
> Why not check dmi years for this test and do the test only for board
> before 2000 ? Better safe than sorry
>
> Bastien
>
>
>
>> included broken EPP support. The Linux parport driver was written to detect
>> such a chipset and disable EPP support on it. Unfortunately the test that was
>> written gives false positives for many current chipsets and no-one seems to
>> know exactly what the problem hardware was, let alone have a sample of it to
>> see if a better test can be written. After such a long time it is probably
>> appropriate to just remove the test (on average it does more harm than good)
>> however you are correct in asserting the driver is unmaintained so no-one is
>> bothering to fix it.
>> </quote>
>>
>> I have applied the patch to the standard debian kernel and vanilla kernels and
>> runs perfectly. The patch simply erases a check. Applied to some Dell
>> hardware, now the EPP mode is detected and, after some initial tests it's
>> working.
>>
>> Please, apply the patch.
>>
>> Best regards,
>>
>> Leo
>>
>> [1] http://lists.infradead.org/pipermail/linux-parport/2008-March/000628.html
>> [2] https://bugzilla.redhat.com/show_bug.cgi?id=284471
>>
>>
>> Signed-off-by: Adam Baker <linux at baker-net.org.uk>
>> Signed-off-by: Leopold Palomo-Avellaneda <leo@alaxarxa.net>
>>
>>
>> ---
>>
>



Reply to: