On 08/29/2011 02:40 PM, Ben Hutchings wrote: > This is what I've added for 2.6.32-36. Any review would be appreciated. Thanks, Ben! Two crashes i have documentation for show the division-by-zero error happening in find_busiest_group, which was patched in the initial diff i submitted, but not in your patch below. Perhaps this is because the divisor there is sds.total_pwr instead of group->cpu_power. My diff also included cleanups to a possible division-by-zero in * update_group_shares_cpu (divisor: sd_rq_weight), and * find_busiest_queue (divisor: power) which are missing in your patch. Here are backtraces showing find_busiest_group as the innermost function at the time of the error: https://support.mayfirst.org/ticket/4423 https://support.mayfirst.org/ticket/4343 Could you cover at least find_busiest_group() in your patch? I'd propose it myself, but your patch introduced me to several C concepts i'm only starting to make sense of (sorry, i'm a kernel n00b), so i don't think my edits would be very useful to you. Thanks very much for sorting this out and for your sensible approach to trying to learn more about the problem rather than just papering it over. Regards, --dkg
Attachment:
signature.asc
Description: OpenPGP digital signature