Bug#631187: Kernel panics when removing external hard drive

[Jonathan Nieder <jrnieder@gmail.com>]

Hi Ben,

Ben Hutchings wrote:

> There is a byte missing between the two lines (in fact, the very byte
> which RIP points to), and you are mixing decimal and hexadecimal
> offsets.
>
> In fact RIP is pointing into the second half of this test:
>
> 		if ((rq->cmd_flags & REQ_SORTED) &&
> 		    e->ops->elevator_completed_req_fn)
>
> and e->ops was NULL.

Ah, that makes sense.

> This might be fixed by:
>
> commit 0769e21bf4b5cf48878c1ca819276e80465b39e7
> Author: James Bottomley <James.Bottomley@HansenPartnership.com>
> Date:   Wed May 25 15:52:14 2011 -0500
>
>     Fix oops caused by queue refcounting failure
>
>     commit e73e079bf128d68284efedeba1fbbc18d78610f9 upstream.

As does that.  Thanks for explaining.