On Sun, Jun 05, 2011 at 08:23:20PM +0200, Hector Oron wrote: > Hello, > > 2011/6/5 Ben Hutchings <ben@decadent.org.uk>: > > On Mon, 2011-05-30 at 22:09 +0200, Sebastian Reichel wrote: > >> [0] http://pkg-n900.alioth.debian.org/kernel/linux-2.6-omap.patch > >> sha256 24958a765f5291c3a34edd31aeac2ec2a1756d17c2b11389b639ea19d68734be > > > Could you review this, please? Especially the changes to the common > > armhf/config. > > --- debian/config/armhf/config 2011-05-30 19:21:33.000000000 +0200 > +++ debian-omap/config/armhf/config 2011-05-25 14:01:47.000000000 +0200 > @@ -5,6 +5,13 @@ > CONFIG_ATAGS_PROC=y > #. Enable floating point unit > CONFIG_VFP=y > +CONFIG_VFPv3=y > > No need this symbol as CONFIG_VFPv3 default y if CPU_V7 > > +## > +## file: arch/arm/mm/Kconfig > +## > +CONFIG_CPU_V7=y > > This symbol is not needed as it should be selected by ARCH symbols, i.e. > http://lxr.linux.no/linux+v2.6.39/arch/arm/mach-omap2/Kconfig#L31 > > If some platform being ARMv7 does not select it I would consider it a > bug on kernel config. These were meant as "better safe than sorry" options. The kernel won't be able to boot the system if the default changes. > +CONFIG_ARM_THUMBEE=y > > THUMBEE selects CPU_V7, but not all ARMv7 support THUMBEE (fact that I > need to check). Could you consider this symbol for the subarch > specific configuration part? sure. I mixed up THUMB2 (which is required by armhf) and THUMBEE. > Sebastian, which OMAP platforms do you plan to enable? OMAP3 and OMAP4. Probably OMAP5 can also be added once there is linux support for it. If you mean the enabled boards: all. I only checked that all needed drivers are enabled for Nokia N900 and Pandaboard, though (I only own these devices). -- Sebastian
Attachment:
signature.asc
Description: Digital signature