[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#603858: Mount options for proc conflict with /etc/fstab breaking /etc/init.d/mountall.sh



On Sat, 2011-05-14 at 03:27 +0200, Goswin von Brederlow wrote:
> Ben Hutchings <ben@decadent.org.uk> writes:
> 
> > On Thu, May 12, 2011 at 08:57:18PM +0200, Goswin von Brederlow wrote:
> >> rleigh <rleigh@codelibre.net> writes:
> > [...]
> >> > tmpfs filesystems are different; here they /do/ differ in the sense that
> >> > /run, /run/lock, /lib/init/rw etc. /are/ separate unique instances of
> >> > tmpfs.  Here, it might make sense to give them a name other than "none"
> >> > or "tmpfs" in order to distinguish between them--that is to say, the
> >> > tmpfs instance, rather than the mountpoint.  So names such as "run",
> >> > "runlock", would provide a unique key for /etc/fstab in addition to the
> >> > mountpoint.  But this is mostly cosmetic, and if we do make such a
> >> > change we'll need to ensure that it's coordinated between initscripts
> >> > and initramfs-tools.
> >> 
> >> It really doesn't matter what it is as long as it is consitent. Given
> >> that /run and /run/lock aren't yet in use in Debian now would be the
> >> time to pick a name and then stick with it. Using "run" and "runlock"
> >> sounds good, go with that.
> > [...]
> >  
> > It does matter, as this is not just a matter for initramfs-tools and
> > initscripts.  We also need to agree with systemd and that is cross-
> > distribution.
> >  
> > Ben.
> 
> So what is everyone else using?

systemd version 25 appears to set name equal to type for all virtual
filesystems:

typedef struct MountPoint {
        const char *what;
        const char *where;
        const char *type;
        const char *options;
        unsigned long flags;
        bool fatal;
} MountPoint;

static const MountPoint mount_table[] = {
        { "proc",     "/proc",                  "proc",     NULL,                MS_NOSUID|MS_NOEXEC|MS_NODEV, true },
        { "sysfs",    "/sys",                   "sysfs",    NULL,                MS_NOSUID|MS_NOEXEC|MS_NODEV, true },
        { "devtmpfs", "/dev",                   "devtmpfs", "mode=755",          MS_NOSUID,                    true },
        { "tmpfs",    "/dev/shm",               "tmpfs",    "mode=1777",         MS_NOSUID|MS_NODEV,           true },
        { "devpts",   "/dev/pts",               "devpts",   "mode=620,gid=" STRINGIFY(TTY_GID), MS_NOSUID|MS_NOEXEC, false },
        { "tmpfs",    "/run",                   "tmpfs",    "mode=755",          MS_NOSUID|MS_NOEXEC|MS_NODEV, true },
        { "tmpfs",    "/sys/fs/cgroup",         "tmpfs",    "mode=755",          MS_NOSUID|MS_NOEXEC|MS_NODEV, false },
        { "cgroup",   "/sys/fs/cgroup/systemd", "cgroup",   "none,name=systemd", MS_NOSUID|MS_NOEXEC|MS_NODEV, false },
};

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: