Re: linux-2.6_2.6.38-5_m68k.changes ACCEPTED

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Thu, May 12, 2011 at 04:36, Ben Hutchings <ben@decadent.org.uk> wrote:
>> <stdin>:1522:2: warning: #warning syscall recvmmsg not implemented
>
> Missing feature on m68k.

False positive, as this is implemented via the sys_socketcall() demultiplexer.

>> drivers/net/wireless/p54/main.c: In function 'p54_register_common':
>> drivers/net/wireless/p54/main.c:614: warning: unused variable 'priv'
>> drivers/net/wireless/p54/main.c: In function 'p54_unregister_common':
>> drivers/net/wireless/p54/main.c:656: warning: unused variable 'priv'
>
> Fixed in 2.6.39.

Do we really want to compile wireless on m68k? AFAIK we don't have any.

>> CC [M]  drivers/net/zorro8390.o
>> drivers/net/lib8390.c:256: warning: '__ei_tx_timeout' defined but not used
>> drivers/net/lib8390.c:302: warning: '__ei_start_xmit' defined but not used
>> drivers/net/lib8390.c:526: warning: '__ei_poll' defined but not used
>> drivers/net/lib8390.c:879: warning: '__ei_get_stats' defined but not used
>> drivers/net/lib8390.c:981: warning: '__ei_set_multicast_list' defined but not used
>> drivers/net/lib8390.c:1016: warning: '____alloc_ei_netdev' defined but not used
>
> It looks like zorro8390.c should be using these functions instead of the
> corresponding functions without the double-underscore prefixes.  At the
> moment it's using some functions built from the #included lib8390.c
> using the special definition of EI_SHIFT (from zorro8390.c), and some
> functions exported from the 8390 module, which are built with the
> default definition of EI_SHIFT (from 8390.h).
>
>> CC [M]  drivers/net/hydra.o
>> drivers/net/lib8390.c:256: warning: '__ei_tx_timeout' defined but not used
>> drivers/net/lib8390.c:302: warning: '__ei_start_xmit' defined but not used
>> drivers/net/lib8390.c:526: warning: '__ei_poll' defined but not used
>> drivers/net/lib8390.c:879: warning: '__ei_get_stats' defined but not used
>> drivers/net/lib8390.c:981: warning: '__ei_set_multicast_list' defined but not used
>> drivers/net/lib8390.c:1016: warning: '____alloc_ei_netdev' defined but not used
>
> Similar issue in hydra.c.

Will be fixed. Turned out to be a real bug recently.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds