[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#607416: marked as done (Device table incorrect for drivers/s390/block/dasd_eckd.c: 3880/3390 should be 3880/3380. (s390/s390x only))

Your message dated Thu, 14 Apr 2011 00:00:34 -0500
with message-id <20110414050002.GA2002@elie>
and subject line Re: Device table incorrect for drivers/s390/block/dasd_eckd.c: 3880/3390 should be 3880/3380
has caused the Debian Bug report #607416,
regarding Device table incorrect for drivers/s390/block/dasd_eckd.c: 3880/3390 should be 3880/3380.  (s390/s390x only)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
607416: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607416
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-2.6
Version: 2.6.32-29

The device table in drivers/s390/block/dasd_eckd.c which indicates which
storage control unit and dasd device type combinations are supported by
the driver is incorrect.  The device table indicates that a combination
of 3880 for a control unit and 3390 for a device type is supported.  That
is incorrect.  A 3880 storage control unit will support a 3380 device
type, but not a 3390 device type.  Here is a code excerpt:

static struct ccw_device_id dasd_eckd_ids[] = {
        { CCW_DEVICE_DEVTYPE (0x3990, 0, 0x3390, 0), .driver_info = 0x1},
        { CCW_DEVICE_DEVTYPE (0x2105, 0, 0x3390, 0), .driver_info = 0x2},
        { CCW_DEVICE_DEVTYPE (0x3880, 0, 0x3390, 0), .driver_info = 0x3},  /* bad one! */
        { CCW_DEVICE_DEVTYPE (0x3990, 0, 0x3380, 0), .driver_info = 0x4},
        { CCW_DEVICE_DEVTYPE (0x2105, 0, 0x3380, 0), .driver_info = 0x5},
        { CCW_DEVICE_DEVTYPE (0x9343, 0, 0x9345, 0), .driver_info = 0x6},
        { CCW_DEVICE_DEVTYPE (0x2107, 0, 0x3390, 0), .driver_info = 0x7},
        { CCW_DEVICE_DEVTYPE (0x2107, 0, 0x3380, 0), .driver_info = 0x8},
        { CCW_DEVICE_DEVTYPE (0x1750, 0, 0x3390, 0), .driver_info = 0x9},
        { CCW_DEVICE_DEVTYPE (0x1750, 0, 0x3380, 0), .driver_info = 0xa},
        { /* end of list */ },
};

The bad line should be changed to

        { CCW_DEVICE_DEVTYPE (0x3880, 0, 0x3380, 0), .driver_info = 0x3},  /* corrected */

Other supporting code in the driver may also need to be changed, I don't know.
But I do know that a 3880 storage control unit does not support a 3390 device.
It does support a 3380 device, but that is missing from the table.

This is clearly an issue to be pursued upstream, it is not an issue of
Debian packaging.  But I opened this bug report to have a place to
put upstream correspondence related to this bug.  I will pursue the matter
with upstream, as I did the last kernel bug that I opened.

This is not a release-critical bug and should not delay the process of
making squeeze the stable release.  However, it would be nice if the fix
for this bug eventually made it into a future stable point release.

-- 
  .''`.     Stephen Powell    
 : :'  :
 `. `'`
   `-

--- End Message ---
--- Begin Message --- 
Version: 2.6.38~rc6-1~experimental.1

Hi Stephen,

Stephen Powell wrote:

> I can confirm that the problem reported in this bug report has been fixed in
> linux-source-2.6.38 version 2.6.38-3 (and in binaries derived from that
> source).

Yep, fixed by v2.6.38-rc6~14^2~4 ([S390] dasd: correct device table,
2011-02-17).  Thanks for your persistence.

--- End Message ---
Reply to: