Bug#620331: linux-2.6: igb driver fix for management card detection
On Mon, Apr 04, 2011 at 02:08:41PM +0200, Julien-externe BLACHE wrote:
> ben@decadent.org.uk wrote on 04/04/2011 12:58:24 PM:
>
> Hi,
>
> > I expect that at some point we'll want to update the driver to add new
> > hardware support, and then we'll pick this up along the way. Until
> > then, however, I'm not going to apply it.
>
> I don't understand your decision; upgrading the whole driver is actually a
> lot more likely to introduce regressions, seeing how this driver should be
> at the very least 2 different drivers.
It also results in a version that is closer to that tested by the
upstream developers (and users of more recent distributions).
> I've been working on the igb driver for 5 days, I've read every single
> upstream commit affecting igb since before 2.6.32 and I've read the 82575
> manuals from cover to cover.
So have you verified that there are no earlier or later changes related
to this?
> If you want to see for yourself, Intel document ref. 324632-003, rev. 2.1
> 01/2011, pages 392-393 document the MANC register.
It is naive to believe anything in a hardware manual without testing it!
I assume you have done that, though.
Ben.
> And that'll be it as far as I'm concerned.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
Reply to: